Remove SurfaceFactory::Create and SurfaceFactory::Destroy

components/exo/surface.cc

Index: components/exo/surface.cc
diff --git a/components/exo/surface.cc b/components/exo/surface.cc
index 5edc802f9635be0168c30c9bf197969867378ace..dd5dfd5e77dbdbef6f8d0f13218c547e68fcb69b 100644
--- a/components/exo/surface.cc
+++ b/components/exo/surface.cc
@@ -244,12 +244,10 @@ Surface::~Surface() {
                                  frame_callbacks_);
   for (const auto& frame_callback : active_frame_callbacks_)
     frame_callback.Run(base::TimeTicks());
-
   if (begin_frame_source_ && needs_begin_frame_)
     begin_frame_source_->RemoveObserver(this);
 
-  if (local_frame_id_.is_valid())
-    factory_owner_->surface_factory_->Destroy(local_frame_id_);
+  factory_owner_->surface_factory_->Reset();

[jbauman, 2016/11/11 18:16:47]

This will prevent the resources from being returned at the right time.

[Saman Sami, 2016/11/11 22:28:09]

Replaced with EvictFrame

 
   surface_manager_->UnregisterSurfaceFactoryClient(
       factory_owner_->frame_sink_id_);
@@ -478,7 +476,6 @@ void Surface::CommitSurfaceHierarchy() {
   if (needs_commit_to_new_surface_ || !local_frame_id_.is_valid()) {
     needs_commit_to_new_surface_ = false;
     local_frame_id_ = factory_owner_->id_allocator_->GenerateId();
-    factory_owner_->surface_factory_->Create(local_frame_id_);
   }
 
   UpdateSurface(true);
@@ -486,7 +483,6 @@ void Surface::CommitSurfaceHierarchy() {
   if (old_local_frame_id.is_valid() && old_local_frame_id != local_frame_id_) {
     factory_owner_->surface_factory_->SetPreviousFrameSurface(
         local_frame_id_, old_local_frame_id);
-    factory_owner_->surface_factory_->Destroy(old_local_frame_id);
   }
 
   if (old_local_frame_id != local_frame_id_) {