Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: android_webview/browser/surfaces_instance.cc

Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: up Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/surfaces_instance.cc
diff --git a/android_webview/browser/surfaces_instance.cc b/android_webview/browser/surfaces_instance.cc
index 0f71caa7a623c87bb055ab301d68608190f00bc6..d1d52d7e5826e000d56d6b9d73aa1b59bef5533d 100644
--- a/android_webview/browser/surfaces_instance.cc
+++ b/android_webview/browser/surfaces_instance.cc
@@ -85,8 +85,7 @@ SurfacesInstance::~SurfacesInstance() {
g_surfaces_instance = nullptr;
DCHECK(child_ids_.empty());
- if (root_id_.is_valid())
- surface_factory_->Destroy(root_id_);
+ surface_factory_.reset();
surface_manager_->InvalidateFrameSinkId(frame_sink_id_);
}
@@ -138,7 +137,6 @@ void SurfacesInstance::DrawAndSwap(const gfx::Size& viewport,
if (!root_id_.is_valid()) {
root_id_ = surface_id_allocator_->GenerateId();
- surface_factory_->Create(root_id_);
display_->SetSurfaceId(cc::SurfaceId(frame_sink_id_, root_id_), 1.f);
}
surface_factory_->SubmitCompositorFrame(root_id_, std::move(frame),

Powered by Google App Engine
This is Rietveld 408576698