Remove SurfaceFactory::Create and SurfaceFactory::Destroy

content/browser/frame_host/render_widget_host_view_guest.cc

Index: content/browser/frame_host/render_widget_host_view_guest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index 48ec3e287564e7d4223d350fb0dedbc504ab76a3..7a6de5b3dee234903574305106b7fe65601f9225 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -288,7 +288,6 @@ void RenderWidgetHostViewGuest::OnSwapCompositorFrame(
   // frame renderer has changed its output surface, or size, or scale factor.
   if (compositor_frame_sink_id != last_compositor_frame_sink_id_ &&
       surface_factory_) {
-    surface_factory_->Destroy(local_frame_id_);
     surface_factory_.reset();
   }
   if (compositor_frame_sink_id != last_compositor_frame_sink_id_ ||
@@ -309,7 +308,9 @@ void RenderWidgetHostViewGuest::OnSwapCompositorFrame(
 
   if (local_frame_id_.is_null()) {
     local_frame_id_ = id_allocator_->GenerateId();
-    surface_factory_->Create(local_frame_id_);
+    surface_factory_->SubmitCompositorFrame(local_frame_id_,

[Fady Samuel, 2016/11/08 22:23:59]

I don't think this approach is correct. We shouldn't be submitting empty
compositorframes unless absolutely necessary. Move the destruction dependency
code after SubmitCompositorFrame.

[Saman Sami, 2016/11/11 17:49:58]

Done.

+                                            cc::CompositorFrame(),
+                                            cc::SurfaceFactory::DrawCallback());
 
     cc::SurfaceSequence sequence =
         cc::SurfaceSequence(frame_sink_id_, next_surface_sequence_++);