Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3108)

Unified Diff: cc/test/test_compositor_frame_sink.cc

Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: up Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/test_compositor_frame_sink.cc
diff --git a/cc/test/test_compositor_frame_sink.cc b/cc/test/test_compositor_frame_sink.cc
index 9a7241f642acafe702e09c065718ed4fca582b04..4de89e96c54299368139dc7d8e5bc46cd3ca61d3 100644
--- a/cc/test/test_compositor_frame_sink.cc
+++ b/cc/test/test_compositor_frame_sink.cc
@@ -111,8 +111,6 @@ bool TestCompositorFrameSink::BindToClient(CompositorFrameSinkClient* client) {
void TestCompositorFrameSink::DetachFromClient() {
// Some tests make BindToClient fail on purpose. ^__^
if (bound_) {
- if (!delegated_local_frame_id_.is_null())
- surface_factory_->Destroy(delegated_local_frame_id_);
surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_);
surface_manager_->InvalidateFrameSinkId(frame_sink_id_);
display_ = nullptr;
@@ -130,7 +128,6 @@ void TestCompositorFrameSink::SubmitCompositorFrame(CompositorFrame frame) {
if (delegated_local_frame_id_.is_null()) {
delegated_local_frame_id_ = surface_id_allocator_->GenerateId();
- surface_factory_->Create(delegated_local_frame_id_);
}
display_->SetSurfaceId(SurfaceId(frame_sink_id_, delegated_local_frame_id_),
frame.metadata.device_scale_factor);

Powered by Google App Engine
This is Rietveld 408576698