content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc - Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)

Patch Set: up Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/delegated_frame_host.cc ('k') | content/renderer/android/synchronous_compositor_frame_sink.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

diff --git a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

index f8d139af465b788da27dede44e0b8b1ae9561a3f..2519aa3db42646cc14bf2a557622c341fadfea1c 100644

--- a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

+++ b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

@@ -19,7 +19,6 @@ OffscreenCanvasCompositorFrameSink::OffscreenCanvasCompositorFrameSink(

surface_factory_ = base::MakeUnique<cc::SurfaceFactory>(

surface_id_.frame_sink_id(), manager, this);

manager->RegisterFrameSinkId(surface_id_.frame_sink_id());

- surface_factory_->Create(surface_id_.local_frame_id());

}

OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() {

@@ -31,7 +30,7 @@ OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() {

} else {

manager->InvalidateFrameSinkId(surface_id_.frame_sink_id());

}

- surface_factory_->Destroy(surface_id_.local_frame_id());

+ surface_factory_->EvictSurface();

}

// static