Remove SurfaceFactory::Create and SurfaceFactory::Destroy

cc/surfaces/surface_factory_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/surface_factory.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 55 matching lines @@
 
 class SurfaceFactoryTest : public testing::Test, public SurfaceObserver {
  public:
   SurfaceFactoryTest()
       : factory_(
             new SurfaceFactory(kArbitraryFrameSinkId, &manager_, &client_)),
         local_frame_id_(3, 1),
         frame_sync_token_(GenTestSyncToken(4)),
         consumer_sync_token_(GenTestSyncToken(5)) {
     manager_.AddObserver(this);
-    factory_->Create(local_frame_id_);
+    factory_->SubmitCompositorFrame(local_frame_id_, CompositorFrame(),
+                                    SurfaceFactory::DrawCallback());
   }
 
   const SurfaceId& last_created_surface_id() const {
     return last_created_surface_id_;
   }
 
   // SurfaceObserver implementation.
   void OnSurfaceCreated(const SurfaceId& surface_id,
                         const gfx::Size& frame,
                         float device_scale_factor) override {
     EXPECT_EQ(kArbitraryFrameSinkId, surface_id.frame_sink_id());
     last_created_surface_id_ = surface_id;
   }
 
   void OnSurfaceDamaged(const SurfaceId& id, bool* changed) override {
     *changed = true;
   }
 
   ~SurfaceFactoryTest() override {
-    if (local_frame_id_.is_valid())
-      factory_->Destroy(local_frame_id_);
     manager_.RemoveObserver(this);
   }
 
   void SubmitCompositorFrameWithResources(ResourceId* resource_ids,
                                           size_t num_resource_ids) {
     CompositorFrame frame;
     for (size_t i = 0u; i < num_resource_ids; ++i) {
       TransferableResource resource;
       resource.id = resource_ids[i];
       resource.mailbox_holder.texture_target = GL_TEXTURE_2D;
@@ skipping 320 matching lines @@
     int expected_returned_counts[] = {2, 2};
     CheckReturnedResourcesMatchExpected(
         expected_returned_ids, expected_returned_counts,
         arraysize(expected_returned_counts), consumer_sync_token_);
   }
 }
 
 TEST_F(SurfaceFactoryTest, BlankNoIndexIncrement) {
   LocalFrameId local_frame_id(6, 1);
   SurfaceId surface_id(kArbitraryFrameSinkId, local_frame_id);
-  factory_->Create(local_frame_id);
+  factory_->SubmitCompositorFrame(local_frame_id, CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
   Surface* surface = manager_.GetSurfaceForId(surface_id);
   ASSERT_NE(nullptr, surface);
   EXPECT_EQ(2, surface->frame_index());
-
-  factory_->SubmitCompositorFrame(local_frame_id, CompositorFrame(),
-                                  SurfaceFactory::DrawCallback());
-  EXPECT_EQ(2, surface->frame_index());
   EXPECT_EQ(last_created_surface_id().local_frame_id(), local_frame_id);
-  factory_->Destroy(local_frame_id);
 }
 
-void CreateSurfaceDrawCallback(SurfaceFactory* factory,
-                               uint32_t* execute_count) {
-  LocalFrameId new_id(7, 0);
-  factory->Create(new_id);
-  factory->Destroy(new_id);
-  *execute_count += 1;
-}
-
-TEST_F(SurfaceFactoryTest, AddDuringDestroy) {
-  LocalFrameId local_frame_id(6, 1);
-  factory_->Create(local_frame_id);
-
-  uint32_t execute_count = 0;
-  factory_->SubmitCompositorFrame(
-      local_frame_id, CompositorFrame(),
-      base::Bind(&CreateSurfaceDrawCallback, base::Unretained(factory_.get()),
-                 &execute_count));
-  EXPECT_EQ(0u, execute_count);
-  factory_->Destroy(local_frame_id);
-  EXPECT_EQ(1u, execute_count);
-}
-
-void DrawCallback(uint32_t* execute_count) {
-  *execute_count += 1;
-}
-
-// Tests doing a DestroyAll before shutting down the factory;
-TEST_F(SurfaceFactoryTest, DestroyAll) {
-  LocalFrameId id(7, 1);
-  factory_->Create(id);
+// Tests that SurfaceFactory doesn't return resources after Reset().
+TEST_F(SurfaceFactoryTest, Reset) {
+  LocalFrameId id(7, 0);
 
   TransferableResource resource;
   resource.id = 1;
   resource.mailbox_holder.texture_target = GL_TEXTURE_2D;
   CompositorFrame frame;
   frame.resource_list.push_back(resource);
-  uint32_t execute_count = 0;
   factory_->SubmitCompositorFrame(id, std::move(frame),
-                                  base::Bind(&DrawCallback, &execute_count));
-  EXPECT_EQ(last_created_surface_id().local_frame_id(), id);
-  local_frame_id_ = LocalFrameId();
-  factory_->DestroyAll();
-  EXPECT_EQ(1u, execute_count);
-}
-
-// Tests that SurfaceFactory doesn't return resources after Reset().
-TEST_F(SurfaceFactoryTest, Reset) {
-  LocalFrameId id(7, 0);
-  factory_->Create(id);
-
-  TransferableResource resource;
-  resource.id = 1;
-  resource.mailbox_holder.texture_target = GL_TEXTURE_2D;
-  CompositorFrame frame;
-  frame.resource_list.push_back(resource);
-  uint32_t execute_count = 0;
-  factory_->SubmitCompositorFrame(id, std::move(frame),
-                                  base::Bind(&DrawCallback, &execute_count));
+                                  SurfaceFactory::DrawCallback());
   EXPECT_EQ(last_created_surface_id().local_frame_id(), id);
 
   SurfaceId surface_id(kArbitraryFrameSinkId, id);
   manager_.AddSurfaceReference(SurfaceManager::kRootSurfaceId, surface_id);
   factory_->Reset();
   EXPECT_TRUE(client_.returned_resources().empty());
   manager_.RemoveSurfaceReference(SurfaceManager::kRootSurfaceId, surface_id);
   EXPECT_TRUE(client_.returned_resources().empty());
   local_frame_id_ = LocalFrameId();
 }
 
 TEST_F(SurfaceFactoryTest, DestroySequence) {
   LocalFrameId local_frame_id2(5, 1);
+  std::unique_ptr<SurfaceFactory> factory2(
+      new SurfaceFactory(kArbitraryFrameSinkId, &manager_, &client_));
   SurfaceId id2(kArbitraryFrameSinkId, local_frame_id2);
-  factory_->Create(local_frame_id2);
+  factory2->SubmitCompositorFrame(local_frame_id2, CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
 
   manager_.RegisterFrameSinkId(kArbitraryFrameSinkId);
 
   // Check that waiting before the sequence is satisfied works.
   manager_.GetSurfaceForId(id2)->AddDestructionDependency(
       SurfaceSequence(kArbitraryFrameSinkId, 4));
-  factory_->Destroy(local_frame_id2);
+  factory2->SubmitCompositorFrame(LocalFrameId(0, 0), CompositorFrame(),

[Fady Samuel, 2016/11/10 23:33:37]

If staraz@ lands his patch first then this will not work. LocalFrameId will be
invalid and I think this test will fail.

[danakj, 2016/11/10 23:57:58]

Also if you use 0s to signify nothing instead of Optional. Non-zeros here?

[Saman Sami, 2016/11/11 17:49:59]

Done.

+                                  SurfaceFactory::DrawCallback());
 
   CompositorFrame frame;
   frame.metadata.satisfies_sequences.push_back(6);
   frame.metadata.satisfies_sequences.push_back(4);
   DCHECK(manager_.GetSurfaceForId(id2));
   factory_->SubmitCompositorFrame(local_frame_id_, std::move(frame),
                                   SurfaceFactory::DrawCallback());
-  EXPECT_EQ(last_created_surface_id().local_frame_id(), local_frame_id_);
   DCHECK(!manager_.GetSurfaceForId(id2));
 
   // Check that waiting after the sequence is satisfied works.
-  factory_->Create(local_frame_id2);
+  factory2->SubmitCompositorFrame(local_frame_id2, CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
   DCHECK(manager_.GetSurfaceForId(id2));
   manager_.GetSurfaceForId(id2)->AddDestructionDependency(
       SurfaceSequence(kAnotherArbitraryFrameSinkId, 6));
-  factory_->Destroy(local_frame_id2);
+  factory2->SubmitCompositorFrame(LocalFrameId(0, 1), CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
   DCHECK(!manager_.GetSurfaceForId(id2));
 }
 
 // Tests that Surface ID namespace invalidation correctly allows
 // Sequences to be ignored.
 TEST_F(SurfaceFactoryTest, InvalidFrameSinkId) {
   FrameSinkId frame_sink_id(1234, 5678);
 
   LocalFrameId local_frame_id(5, 1);
   SurfaceId id(factory_->frame_sink_id(), local_frame_id);
-  factory_->Create(local_frame_id);
+  factory_->SubmitCompositorFrame(local_frame_id, CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
 
   manager_.RegisterFrameSinkId(frame_sink_id);
   manager_.GetSurfaceForId(id)->AddDestructionDependency(
       SurfaceSequence(frame_sink_id, 4));
-  factory_->Destroy(local_frame_id);
+
+  LocalFrameId local_frame_id_2(6, 0);
+  factory_->SubmitCompositorFrame(local_frame_id_2, CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
 
   // Verify the dependency has prevented the surface from getting destroyed.
   EXPECT_TRUE(manager_.GetSurfaceForId(id));
 
   manager_.InvalidateFrameSinkId(frame_sink_id);
 
   // Verify that the invalidated namespace caused the unsatisfied sequence
   // to be ignored.
   EXPECT_FALSE(manager_.GetSurfaceForId(id));
 }
 
 TEST_F(SurfaceFactoryTest, DestroyCycle) {
   LocalFrameId local_frame_id2(5, 1);
   SurfaceId id2(kArbitraryFrameSinkId, local_frame_id2);
-  factory_->Create(local_frame_id2);
-
+  std::unique_ptr<SurfaceFactory> factory2(
+      new SurfaceFactory(kArbitraryFrameSinkId, &manager_, &client_));
   manager_.RegisterFrameSinkId(kAnotherArbitraryFrameSinkId);
-
-  manager_.GetSurfaceForId(id2)->AddDestructionDependency(
-      SurfaceSequence(kAnotherArbitraryFrameSinkId, 4));
-
   // Give id2 a frame that references local_frame_id_.
   {
     std::unique_ptr<RenderPass> render_pass(RenderPass::Create());
     CompositorFrame frame;
     frame.render_pass_list.push_back(std::move(render_pass));
     frame.metadata.referenced_surfaces.push_back(
         SurfaceId(factory_->frame_sink_id(), local_frame_id_));
-    factory_->SubmitCompositorFrame(local_frame_id2, std::move(frame),
+    factory2->SubmitCompositorFrame(local_frame_id2, std::move(frame),
                                     SurfaceFactory::DrawCallback());
     EXPECT_EQ(last_created_surface_id().local_frame_id(), local_frame_id2);
   }
-  factory_->Destroy(local_frame_id2);
-
+  manager_.GetSurfaceForId(id2)->AddDestructionDependency(
+      SurfaceSequence(kAnotherArbitraryFrameSinkId, 4));
+  factory2->SubmitCompositorFrame(LocalFrameId(0, 0), CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
   // Give local_frame_id_ a frame that references id2.
   {
     std::unique_ptr<RenderPass> render_pass(RenderPass::Create());
     CompositorFrame frame;
     frame.render_pass_list.push_back(std::move(render_pass));
     frame.metadata.referenced_surfaces.push_back(id2);
     factory_->SubmitCompositorFrame(local_frame_id_, std::move(frame),
                                     SurfaceFactory::DrawCallback());
-    EXPECT_EQ(last_created_surface_id().local_frame_id(), local_frame_id_);
   }
-  factory_->Destroy(local_frame_id_);
+  factory_->SubmitCompositorFrame(LocalFrameId(0, 1), CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
   EXPECT_TRUE(manager_.GetSurfaceForId(id2));
   // local_frame_id_ should be retained by reference from id2.
   EXPECT_TRUE(manager_.GetSurfaceForId(
       SurfaceId(factory_->frame_sink_id(), local_frame_id_)));
 
   // Satisfy last destruction dependency for id2.
   std::vector<uint32_t> to_satisfy;
   to_satisfy.push_back(4);
   manager_.DidSatisfySequences(kAnotherArbitraryFrameSinkId, &to_satisfy);
 
@@ skipping 48 matching lines @@
   request = CopyOutputRequest::CreateRequest(
       base::Bind(&CopyRequestTestCallback, &called3));
   request->set_source(source1);
 
   factory_->RequestCopyOfSurface(local_frame_id_, std::move(request));
   // Two callbacks are from source1, so the first should be called.
   EXPECT_TRUE(called1);
   EXPECT_FALSE(called2);
   EXPECT_FALSE(called3);
 
-  factory_->Destroy(local_frame_id_);
   local_frame_id_ = LocalFrameId();
+  factory_->SubmitCompositorFrame(local_frame_id_, CompositorFrame(),
+                                  SurfaceFactory::DrawCallback());
   EXPECT_TRUE(called1);
   EXPECT_TRUE(called2);
   EXPECT_TRUE(called3);
 }
 
 }  // namespace
 }  // namespace cc