Remove SurfaceFactory::Create and SurfaceFactory::Destroy

cc/surfaces/surface_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/surface_factory.h"
 
 #include <utility>
 
 #include "base/trace_event/trace_event.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_factory_client.h"
 #include "cc/surfaces/surface_manager.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace cc {
 SurfaceFactory::SurfaceFactory(const FrameSinkId& frame_sink_id,
                                SurfaceManager* manager,
                                SurfaceFactoryClient* client)
     : frame_sink_id_(frame_sink_id),
       manager_(manager),
       client_(client),
       holder_(client),
       needs_sync_points_(true),
       weak_factory_(this) {}
 
 SurfaceFactory::~SurfaceFactory() {
-  if (!surface_map_.empty()) {

[danakj, 2016/11/10 23:57:58]

Can we enforce this still?

[Fady Samuel, 2016/11/11 00:03:01]

Why? What does that solve? This CL eliminates explicit Create/Destroy in order
to better match the CompositorFrameSink API. The last surface will be destroyed
here. 

[danakj, 2016/11/11 00:10:47]

Cuz this is why there's all the null checks unless I'm misunderstanding.

[Saman Sami, 2016/11/11 17:49:58]

I got rid of the null checks. I still don't have this error message in my last
patch.

-    LOG(ERROR) << "SurfaceFactory has " << surface_map_.size()
-               << " entries in map on destruction.";
-  }
   DestroyAll();
 }
 
 void SurfaceFactory::DestroyAll() {
   if (manager_) {
     for (auto& pair : surface_map_)
       manager_->Destroy(std::move(pair.second));
   }
   surface_map_.clear();
+  last_local_frame_id_.reset();
 }
 
 void SurfaceFactory::Reset() {
   DestroyAll();
   // Disown Surfaces that are still alive so that they don't try to unref
   // resources that we're not tracking any more.
   weak_factory_.InvalidateWeakPtrs();
   holder_.Reset();
 }
 
@@ skipping 23 matching lines @@
       manager_->GetSurfaceForId(SurfaceId(frame_sink_id_, old_id));
   if (old_surface) {
     it->second->SetPreviousFrameSurface(old_surface);
   }
 }
 
 void SurfaceFactory::SubmitCompositorFrame(const LocalFrameId& local_frame_id,
                                            CompositorFrame frame,
                                            const DrawCallback& callback) {
   TRACE_EVENT0("cc", "SurfaceFactory::SubmitCompositorFrame");
+  if (!last_local_frame_id_ || local_frame_id != *last_local_frame_id_) {
+    Create(local_frame_id);
+  }
   OwningSurfaceMap::iterator it = surface_map_.find(local_frame_id);
   DCHECK(it != surface_map_.end());
   DCHECK(it->second->factory().get() == this);
   // Tell the SurfaceManager if this is the first frame submitted with this
   // LocalFrameId.
   if (!it->second->HasFrame()) {
     float device_scale_factor = frame.metadata.device_scale_factor;
     gfx::Size frame_size;
     // CompositorFrames may not be populated with a RenderPass in unit tests.
     if (!frame.render_pass_list.empty())
       frame_size = frame.render_pass_list[0]->output_rect.size();
     manager_->SurfaceCreated(it->second->surface_id(), frame_size,
                              device_scale_factor);
   }
   it->second->QueueFrame(std::move(frame), callback);
   if (!manager_->SurfaceModified(SurfaceId(frame_sink_id_, local_frame_id))) {
     TRACE_EVENT_INSTANT0("cc", "Damage not visible.", TRACE_EVENT_SCOPE_THREAD);
     it->second->RunDrawCallbacks();
   }
+  if (last_local_frame_id_ && local_frame_id != *last_local_frame_id_)
+    Destroy(*last_local_frame_id_);
+  last_local_frame_id_ = local_frame_id;

[danakj, 2016/11/10 23:57:58]

instead of last_ maybe this is current_ ? last sounds like previous and seems
misleading here

[Saman Sami, 2016/11/11 17:49:59]

Done.

 }
 
 void SurfaceFactory::RequestCopyOfSurface(
     const LocalFrameId& local_frame_id,
     std::unique_ptr<CopyOutputRequest> copy_request) {
   OwningSurfaceMap::iterator it = surface_map_.find(local_frame_id);
   if (it == surface_map_.end()) {
     copy_request->SendEmptyResult();
     return;
   }
   DCHECK(it->second->factory().get() == this);
   it->second->RequestCopyOfOutput(std::move(copy_request));
   manager_->SurfaceModified(SurfaceId(frame_sink_id_, local_frame_id));
 }
 
 void SurfaceFactory::WillDrawSurface(const LocalFrameId& id,
                                      const gfx::Rect& damage_rect) {
-  client_->WillDrawSurface(id, damage_rect);
+  if (client_)

[Fady Samuel, 2016/11/10 23:33:37]

Is this check necessary?

[Saman Sami, 2016/11/11 17:49:58]

Removed

+    client_->WillDrawSurface(id, damage_rect);
 }
 
 void SurfaceFactory::ReceiveFromChild(
     const TransferableResourceArray& resources) {
   holder_.ReceiveFromChild(resources);
 }
 
 void SurfaceFactory::RefResources(const TransferableResourceArray& resources) {
   holder_.RefResources(resources);
 }
 
 void SurfaceFactory::UnrefResources(const ReturnedResourceArray& resources) {
   holder_.UnrefResources(resources);
 }
 
 }  // namespace cc