Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2485463002: Fix scoped_nsobject move constructor. (Closed)

Created:
4 years, 1 month ago by dubovtsev
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix scoped_nsobject move constructor. We should use explicit cast here. BUG=none Committed: https://crrev.com/1675277ec91936c10a89f65fe7ed8e013388d7cc Cr-Commit-Position: refs/heads/master@{#430249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M base/mac/scoped_nsobject.h View 3 chunks +4 lines, -3 lines 0 comments Download
M base/mac/scoped_nsobject_unittest.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dubovtsev
Please take a look.
4 years, 1 month ago (2016-11-05 15:19:20 UTC) #3
Nico
lgtm, thanks.
4 years, 1 month ago (2016-11-07 00:47:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485463002/1
4 years, 1 month ago (2016-11-07 10:32:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 11:09:46 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 11:11:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1675277ec91936c10a89f65fe7ed8e013388d7cc
Cr-Commit-Position: refs/heads/master@{#430249}

Powered by Google App Engine
This is Rietveld 408576698