third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl - Issue 2485443002: Change WebGL API arg nullable behavior.

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

Issue 2485443002: Change WebGL API arg nullable behavior. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

index 0ab8f856a3bc609f3f0a515c6a0dca51b3d3dae1..77bf704add2407654e6a3f0ff1554d78824cd5f5 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

@@ -472,8 +472,8 @@ typedef unrestricted float GLclampf;

readonly attribute GLsizei drawingBufferHeight;

void activeTexture(GLenum texture);

- void attachShader(WebGLProgram? program, WebGLShader? shader);

- void bindAttribLocation(WebGLProgram? program, GLuint index, DOMString name);

+ void attachShader(WebGLProgram program, WebGLShader shader);

+ void bindAttribLocation(WebGLProgram program, GLuint index, DOMString name);

void bindBuffer(GLenum target, WebGLBuffer? buffer);

void bindFramebuffer(GLenum target, WebGLFramebuffer? framebuffer);

void bindRenderbuffer(GLenum target, WebGLRenderbuffer? renderbuffer);

@@ -489,7 +489,7 @@ typedef unrestricted float GLclampf;

void bufferData(GLenum target, ArrayBufferView data, GLenum usage);

void bufferData(GLenum target, ArrayBuffer? data, GLenum usage);

void bufferSubData(GLenum target, GLintptr offset, [FlexibleArrayBufferView] ArrayBufferView data);

- void bufferSubData(GLenum target, GLintptr offset, ArrayBuffer? data);

+ void bufferSubData(GLenum target, GLintptr offset, ArrayBuffer data);

GLenum checkFramebufferStatus(GLenum target);

void clear(GLbitfield mask);

@@ -497,7 +497,7 @@ typedef unrestricted float GLclampf;

void clearDepth(GLclampf depth);

void clearStencil(GLint s);

void colorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha);

- void compileShader(WebGLShader? shader);

+ void compileShader(WebGLShader shader);

void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat,

GLsizei width, GLsizei height, GLint border, ArrayBufferView data);

@@ -526,7 +526,7 @@ typedef unrestricted float GLclampf;

void depthFunc(GLenum func);

void depthMask(GLboolean flag);

void depthRange(GLclampf zNear, GLclampf zFar);

- void detachShader(WebGLProgram? program, WebGLShader? shader);

+ void detachShader(WebGLProgram program, WebGLShader shader);

void disable(GLenum cap);

void disableVertexAttribArray(GLuint index);

void drawArrays(GLenum mode, GLint first, GLsizei count);

@@ -541,12 +541,12 @@ typedef unrestricted float GLclampf;

void frontFace(GLenum mode);

void generateMipmap(GLenum target);

- WebGLActiveInfo getActiveAttrib(WebGLProgram? program, GLuint index);

- WebGLActiveInfo getActiveUniform(WebGLProgram? program, GLuint index);

+ WebGLActiveInfo getActiveAttrib(WebGLProgram program, GLuint index);

+ WebGLActiveInfo getActiveUniform(WebGLProgram program, GLuint index);

- sequence<WebGLShader>? getAttachedShaders(WebGLProgram? program);

+ sequence<WebGLShader>? getAttachedShaders(WebGLProgram program);

- GLint getAttribLocation(WebGLProgram? program, DOMString name);

+ GLint getAttribLocation(WebGLProgram program, DOMString name);

[CallWith=ScriptState] any getBufferParameter(GLenum target, GLenum pname);

@@ -558,24 +558,24 @@ typedef unrestricted float GLclampf;

[CallWith=ScriptState] any getFramebufferAttachmentParameter(GLenum target, GLenum attachment, GLenum pname);

[CallWith=ScriptState] any getParameter(GLenum pname);

- [CallWith=ScriptState] any getProgramParameter(WebGLProgram? program, GLenum pname);

- DOMString? getProgramInfoLog(WebGLProgram? program);

+ [CallWith=ScriptState] any getProgramParameter(WebGLProgram program, GLenum pname);

+ DOMString? getProgramInfoLog(WebGLProgram program);

[CallWith=ScriptState] any getRenderbufferParameter(GLenum target, GLenum pname);

- [CallWith=ScriptState] any getShaderParameter(WebGLShader? shader, GLenum pname);

+ [CallWith=ScriptState] any getShaderParameter(WebGLShader shader, GLenum pname);

- DOMString? getShaderInfoLog(WebGLShader? shader);

+ DOMString? getShaderInfoLog(WebGLShader shader);

WebGLShaderPrecisionFormat getShaderPrecisionFormat(GLenum shadertype, GLenum precisiontype);

- DOMString? getShaderSource(WebGLShader? shader);

+ DOMString? getShaderSource(WebGLShader shader);

sequence<DOMString>? getSupportedExtensions();

[CallWith=ScriptState] any getTexParameter(GLenum target, GLenum pname);

- [CallWith=ScriptState] any getUniform(WebGLProgram? program, WebGLUniformLocation? location);

+ [CallWith=ScriptState] any getUniform(WebGLProgram program, WebGLUniformLocation location);

- WebGLUniformLocation getUniformLocation(WebGLProgram? program, DOMString name);

+ WebGLUniformLocation getUniformLocation(WebGLProgram program, DOMString name);

[CallWith=ScriptState] any getVertexAttrib(GLuint index, GLenum pname);

@@ -591,7 +591,7 @@ typedef unrestricted float GLclampf;

GLboolean isShader(WebGLShader? shader);

GLboolean isTexture(WebGLTexture? texture);

void lineWidth(GLfloat width);

- void linkProgram(WebGLProgram? program);

+ void linkProgram(WebGLProgram program);

void pixelStorei(GLenum pname, GLint param);

void polygonOffset(GLfloat factor, GLfloat units);

@@ -600,7 +600,7 @@ typedef unrestricted float GLclampf;

void renderbufferStorage(GLenum target, GLenum internalformat, GLsizei width, GLsizei height);

void sampleCoverage(GLclampf value, GLboolean invert);

void scissor(GLint x, GLint y, GLsizei width, GLsizei height);

- void shaderSource(WebGLShader? shader, DOMString string);

+ void shaderSource(WebGLShader shader, DOMString string);

void stencilFunc(GLenum func, GLint ref, GLuint mask);

void stencilFuncSeparate(GLenum face, GLenum func, GLint ref, GLuint mask);

void stencilMask(GLuint mask);

@@ -620,7 +620,7 @@ typedef unrestricted float GLclampf;

GLenum format, GLenum type, ArrayBufferView? pixels);

void texImage2D(

GLenum target, GLint level, GLint internalformat,

- GLenum format, GLenum type, ImageData? pixels);

+ GLenum format, GLenum type, ImageData pixels);

[RaisesException] void texImage2D(

GLenum target, GLint level, GLint internalformat,

GLenum format, GLenum type, HTMLImageElement image);

@@ -640,7 +640,7 @@ typedef unrestricted float GLclampf;

GLenum format, GLenum type, ArrayBufferView? pixels);

void texSubImage2D(

GLenum target, GLint level, GLint xoffset, GLint yoffset,

- GLenum format, GLenum type, ImageData? pixels);

+ GLenum format, GLenum type, ImageData pixels);

[RaisesException] void texSubImage2D(

GLenum target, GLint level, GLint xoffset, GLint yoffset,

GLenum format, GLenum type, HTMLImageElement image);

@@ -687,7 +687,7 @@ typedef unrestricted float GLclampf;

void uniformMatrix4fv(WebGLUniformLocation? location, GLboolean transpose, sequence<GLfloat> array);

void useProgram(WebGLProgram? program);

- void validateProgram(WebGLProgram? program);

+ void validateProgram(WebGLProgram program);

void vertexAttrib1f(GLuint indx, GLfloat x);

void vertexAttrib1fv(GLuint indx, Float32Array values);