Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2485443002: Change WebGL API arg nullable behavior. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change WebGL API arg nullable behavior. This is due to a spec change. BUG=662520 TEST=webgl_conformance,webgl2_conformance R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/951e541c5dcd9578b3b9653cdc1a6a8c6d5c03cb Cr-Commit-Position: refs/heads/master@{#430154}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -68 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 2 chunks +2 lines, -11 lines 1 comment Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 6 chunks +8 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl View 11 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Zhenyao Mo
kbr: PTAL
4 years, 1 month ago (2016-11-05 01:41:32 UTC) #4
Ken Russell (switch to Gerrit)
Awesome work making these changes so thoroughly. I double-checked them and they look perfect. LGTM ...
4 years, 1 month ago (2016-11-05 05:14:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485443002/20001
4 years, 1 month ago (2016-11-05 06:17:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-05 06:21:58 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 06:24:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/951e541c5dcd9578b3b9653cdc1a6a8c6d5c03cb
Cr-Commit-Position: refs/heads/master@{#430154}

Powered by Google App Engine
This is Rietveld 408576698