Adding smi cache

src/ast/ast-value-factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 312 matching lines @@
   AstValue* value = new (zone_) AstValue(name);
   return AddValue(value);
 }
 
 
 const AstValue* AstValueFactory::NewNumber(double number, bool with_dot) {
   AstValue* value = new (zone_) AstValue(number, with_dot);
   return AddValue(value);
 }
 
-
-const AstValue* AstValueFactory::NewSmi(int number) {
-  AstValue* value =
-      new (zone_) AstValue(AstValue::SMI, number);
-  return AddValue(value);
+const AstValue* AstValueFactory::NewSmi(uint32_t number) {

[vogelheim, 2016/11/09 15:04:10]

[nitpick, and purely a matter of personal preferences. Decide as you see fit.]

Nitpick: I find the nested if-s w/ partially the same code to be hard to read,
given the fairly simple logic. Maybe write like this:

bool cacheable_smi = number <= kMaxCachedSmi;
if (cacheable_smi && smis_[number] != nullptr)
  return smis_[number];

AstValue* value = new ...
if (cacheable_smi)
  smis_[number] = value;
return AddValue(value);

+  if (number <= kMaxCachedSmi) {
+    if (smis_[number] == nullptr) {
+      AstValue* value = new (zone_) AstValue(AstValue::SMI, number);
+      smis_[number] = AddValue(value);
+    }
+    return smis_[number];
+  } else {
+    AstValue* value = new (zone_) AstValue(AstValue::SMI, number);
+    return AddValue(value);
+  }
 }
 
 #define GENERATE_VALUE_GETTER(value, initializer)        \
   if (!value) {                                          \
     value = AddValue(new (zone_) AstValue(initializer)); \
   }                                                      \
   return value;
 
 const AstValue* AstValueFactory::NewBoolean(bool b) {
   if (b) {
@@ skipping 70 matching lines @@
                                   length) == 0;
     } else {
       return CompareCharsUnsigned(reinterpret_cast<const uint16_t*>(l),
                                   reinterpret_cast<const uint16_t*>(r),
                                   length) == 0;
     }
   }
 }
 }  // namespace internal
 }  // namespace v8