Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2485383007: Make perf android tests use devil adb (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Only run on android #

Patch Set 3 : Use adb path. #

Patch Set 4 : ~ #

Total comments: 6

Patch Set 5 : Move adb path setting around. #

Patch Set 6 : Only use devil adb for setup. #

Total comments: 3

Patch Set 7 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+751 lines, -240 lines) Patch
M scripts/slave/recipe_modules/chromium/__init__.py View 1 2 3 4 5 6 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 2 3 4 5 11 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 2 3 4 5 7 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
martiniss
PTAL
4 years, 1 month ago (2016-11-11 22:43:21 UTC) #2
jbudorick
https://codereview.chromium.org/2485383007/diff/60001/scripts/slave/recipe_modules/chromium/__init__.py File scripts/slave/recipe_modules/chromium/__init__.py (right): https://codereview.chromium.org/2485383007/diff/60001/scripts/slave/recipe_modules/chromium/__init__.py#newcode10 scripts/slave/recipe_modules/chromium/__init__.py:10: 'adb', nit: alphabetical, plz https://codereview.chromium.org/2485383007/diff/60001/scripts/slave/recipe_modules/chromium/__init__.py#newcode11 scripts/slave/recipe_modules/chromium/__init__.py:11: nit: blank line? ...
4 years, 1 month ago (2016-11-11 22:47:57 UTC) #4
martiniss
https://codereview.chromium.org/2485383007/diff/60001/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json File scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json (right): https://codereview.chromium.org/2485383007/diff/60001/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json#newcode328 scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json:328: "[BUILDER_CACHE]/Android_Nexus5_Perf__1_/src/third_party/android_tools/sdk/platform-tools/adb", On 2016/11/11 at 22:47:57, jbudorick wrote: > We ...
4 years, 1 month ago (2016-11-11 23:54:39 UTC) #5
jbudorick
lgtm https://codereview.chromium.org/2485383007/diff/100001/scripts/slave/recipe_modules/chromium/__init__.py File scripts/slave/recipe_modules/chromium/__init__.py (right): https://codereview.chromium.org/2485383007/diff/100001/scripts/slave/recipe_modules/chromium/__init__.py#newcode5 scripts/slave/recipe_modules/chromium/__init__.py:5: 'depot_tools/tryserver', On 2016/11/11 23:54:39, martiniss wrote: > spaces ...
4 years, 1 month ago (2016-11-14 16:04:20 UTC) #6
ghost stip (do not use)
lgtm w/ nit https://codereview.chromium.org/2485383007/diff/100001/scripts/slave/recipe_modules/chromium/__init__.py File scripts/slave/recipe_modules/chromium/__init__.py (right): https://codereview.chromium.org/2485383007/diff/100001/scripts/slave/recipe_modules/chromium/__init__.py#newcode4 scripts/slave/recipe_modules/chromium/__init__.py:4: 'depot_tools/gclient', # in order to have ...
4 years, 1 month ago (2016-11-14 21:29:25 UTC) #7
martiniss
On 2016/11/14 at 16:04:20, jbudorick wrote: > lgtm > > https://codereview.chromium.org/2485383007/diff/100001/scripts/slave/recipe_modules/chromium/__init__.py > File scripts/slave/recipe_modules/chromium/__init__.py (right): ...
4 years, 1 month ago (2016-11-14 23:14:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485383007/120001
4 years, 1 month ago (2016-11-14 23:15:17 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:29:01 UTC) #13
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/tools/build/+/d5996676fc740b9c4455...

Powered by Google App Engine
This is Rietveld 408576698