[android] Tweak data deps to include two chromium tool binaries. (RELAND)

[android] Tweak data deps to include two chromium tool binaries. (RELAND)

This includes:
 - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously
    only depended on the symlink, not the target thereof
 - //build/android/pylib/device/commands -- we previously only had it set
    as a dependency of the forwarder & incremental APKs

This should prevent bots running chromium tests from downloading the devil
versions stored in GS.

BUG=664211, 664423
Committed: https://crrev.com/302e4da2da2463a360e26beb8cb88766c48ab6db
Cr-Commit-Position: refs/heads/master@{#431611}

[jbudorick, 2016-11-11 17:43:35]

jbudorick@chromium.org changed reviewers:
+ dpranke@chromium.org

[jbudorick, 2016-11-11 17:43:36]

When building a binary_symlink target with the original change, only the symlink
was being built, not the binary to which the symlink pointed. This was
definitely unexpected given data_deps's help text.

I'm not sure that listing the binary_label in both deps and data_deps is the
best way to ensure that the target both gets built and is listed in the runtime
dependencies, but it does seem to work.

ptal

[jbudorick, 2016-11-11 17:44:06]

Description was changed from

==========
[android] Tweak data deps to include two chromium tool binaries. (RELAND)

This includes:
 - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously
    only depended on the symlink, not the target thereof
 - //build/android/pylib/device/commands -- we previously only had it set
    as a dependency of the forwarder & incremental APKs

This should prevent bots running chromium tests from downloading the devil
versions stored in GS.

BUG=664211
==========

to

==========
[android] Tweak data deps to include two chromium tool binaries. (RELAND)

This includes:
 - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously
    only depended on the symlink, not the target thereof
 - //build/android/pylib/device/commands -- we previously only had it set
    as a dependency of the forwarder & incremental APKs

This should prevent bots running chromium tests from downloading the devil
versions stored in GS.

BUG=664211,664423
==========

[Dirk Pranke, 2016-11-11 17:50:12]

lgtm

[jbudorick, 2016-11-11 18:05:42]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-11-11 18:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:13:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-11 19:30:32]

Description was changed from

==========
[android] Tweak data deps to include two chromium tool binaries. (RELAND)

This includes:
 - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously
    only depended on the symlink, not the target thereof
 - //build/android/pylib/device/commands -- we previously only had it set
    as a dependency of the forwarder & incremental APKs

This should prevent bots running chromium tests from downloading the devil
versions stored in GS.

BUG=664211,664423
==========

to

==========
[android] Tweak data deps to include two chromium tool binaries. (RELAND)

This includes:
 - //tools/android/md5sum:md5sum_bin($host_toolchain) -- we had previously
    only depended on the symlink, not the target thereof
 - //build/android/pylib/device/commands -- we previously only had it set
    as a dependency of the forwarder & incremental APKs

This should prevent bots running chromium tests from downloading the devil
versions stored in GS.

BUG=664211,664423

Committed: https://crrev.com/302e4da2da2463a360e26beb8cb88766c48ab6db
Cr-Commit-Position: refs/heads/master@{#431611}
==========

[commit-bot: I haz the power, 2016-11-11 19:30:33]

Patchset 2 (id:??) landed as
https://crrev.com/302e4da2da2463a360e26beb8cb88766c48ab6db
Cr-Commit-Position: refs/heads/master@{#431611}