Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2485373003: Drop finalization for ElementShadows. (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years ago
Reviewers:
hayato, kochi, rune
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop finalization for ElementShadows. The empty destructor serves no purpose now, so let it go. R= BUG= Committed: https://crrev.com/65717641426b5887e8aa7347c5f5613dc358a866 Cr-Commit-Position: refs/heads/master@{#433844}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
sof
please take a look.
4 years, 1 month ago (2016-11-22 10:59:59 UTC) #8
rune
lgtm
4 years, 1 month ago (2016-11-22 12:14:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485373003/20001
4 years, 1 month ago (2016-11-22 13:01:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 13:05:32 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/65717641426b5887e8aa7347c5f5613dc358a866 Cr-Commit-Position: refs/heads/master@{#433844}
4 years, 1 month ago (2016-11-22 13:06:57 UTC) #18
kochi
4 years ago (2016-11-24 02:34:44 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698