Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by sof Modified:
4 years ago Reviewers:
hayato, kochi, rune CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDrop finalization for ElementShadows.
The empty destructor serves no purpose now, so let it go.
R=
BUG=
Committed: https://crrev.com/65717641426b5887e8aa7347c5f5613dc358a866
Cr-Commit-Position: refs/heads/master@{#433844}
Patch Set 1 #Patch Set 2 : rebased #
Created: 4 years, 1 month ago
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sigbjornf@opera.com changed reviewers: + hayato@chromium.org, kochi@chromium.org
please take a look.
rune@opera.com changed reviewers: + rune@opera.com
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479819691735860,
"parent_rev": "562707a9cb4ae475c03019b5caaad6b8778ade94", "commit_rev":
"f44da8e2c8f55c58f19451aec3d13c4ec2c0459b"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Drop finalization for ElementShadows. The empty destructor serves no purpose now, so let it go. R= BUG= ========== to ========== Drop finalization for ElementShadows. The empty destructor serves no purpose now, so let it go. R= BUG= Committed: https://crrev.com/65717641426b5887e8aa7347c5f5613dc358a866 Cr-Commit-Position: refs/heads/master@{#433844} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/65717641426b5887e8aa7347c5f5613dc358a866 Cr-Commit-Position: refs/heads/master@{#433844}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
