Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2485363002: Revert of Clean up fx_codec_icc.cpp (Closed)

Created:
4 years, 1 month ago by kcwu
Modified:
4 years, 1 month ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Clean up fx_codec_icc.cpp (patchset #1 id:1 of https://codereview.chromium.org/2482663002/ ) Reason for revert: Max cmsChannelsOf() is 15, which is larger than expectation of existing code and cause crashes (at least the fuzzer). BUG=chromium:663240 Original issue's description: > Clean up fx_codec_icc.cpp > > Committed: https://pdfium.googlesource.com/pdfium/+/a94fc11866adb1b9ca4a4e1afb4fb574ed472e07 TBR=dsinclair@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://pdfium.googlesource.com/pdfium/+/1e21c0d076cc6cc61f36a1835dc886f721fdc4d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M core/fxcodec/codec/fx_codec_icc.cpp View 3 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kcwu
Created Revert of Clean up fx_codec_icc.cpp
4 years, 1 month ago (2016-11-09 03:56:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485363002/1
4 years, 1 month ago (2016-11-09 03:57:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-09 03:57:07 UTC) #5
kcwu
4 years, 1 month ago (2016-11-09 03:57:41 UTC) #7
dsinclair
lgtm
4 years, 1 month ago (2016-11-09 13:59:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485363002/1
4 years, 1 month ago (2016-11-09 13:59:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 14:15:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1e21c0d076cc6cc61f36a1835dc886f721fd...

Powered by Google App Engine
This is Rietveld 408576698