Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2485313002: [Media Router] Remove obsolete code and bindings. (Closed)

Created:
4 years, 1 month ago by mark a. foltz
Modified:
4 years, 1 month ago
Reviewers:
imcheng, apacible
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove obsolete code and bindings. - Removes listenForRouteMessages handler - Removes code for non-Promise returning terminateRoute() - Makes origin mandatory for onSinksReceived - Cleans up optional arguments for onRoutesUpdated BUG=626395 Committed: https://crrev.com/aceffa24c81d9399b1cf9ddc626227d5a7c6db88 Cr-Commit-Position: refs/heads/master@{#431124}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Respond to imcheng@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -67 lines) Patch
M extensions/renderer/resources/media_router_bindings.js View 1 5 chunks +14 lines, -67 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mark a. foltz
4 years, 1 month ago (2016-11-09 01:31:45 UTC) #2
imcheng
lgtm % nits https://codereview.chromium.org/2485313002/diff/1/extensions/renderer/resources/media_router_bindings.js File extensions/renderer/resources/media_router_bindings.js (right): https://codereview.chromium.org/2485313002/diff/1/extensions/renderer/resources/media_router_bindings.js#newcode268 extensions/renderer/resources/media_router_bindings.js:268: * @param {Array<string>} origins Can this ...
4 years, 1 month ago (2016-11-09 01:48:47 UTC) #3
mark a. foltz
https://codereview.chromium.org/2485313002/diff/1/extensions/renderer/resources/media_router_bindings.js File extensions/renderer/resources/media_router_bindings.js (right): https://codereview.chromium.org/2485313002/diff/1/extensions/renderer/resources/media_router_bindings.js#newcode268 extensions/renderer/resources/media_router_bindings.js:268: * @param {Array<string>} origins On 2016/11/09 at 01:48:46, imcheng ...
4 years, 1 month ago (2016-11-09 18:15:08 UTC) #4
apacible
lgtm
4 years, 1 month ago (2016-11-09 23:03:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485313002/20001
4 years, 1 month ago (2016-11-10 00:54:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 01:07:33 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 01:22:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aceffa24c81d9399b1cf9ddc626227d5a7c6db88
Cr-Commit-Position: refs/heads/master@{#431124}

Powered by Google App Engine
This is Rietveld 408576698