Add FPDF_FreeDefaultSystemFontInfo API

Add FPDF_FreeDefaultSystemFontInfo API

Added method that will cast into FPDF_SYSFONTINFO_DEFAULT and delete.
This will allow using FPDF_GetDefaultSystemFontInfo() without memory
management problems.

Committed: https://pdfium.googlesource.com/pdfium/+/788217d77c9933614efbd778b6f6ee0008f4f9d9

[npm, 2016-11-08 22:41:05]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:41:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-08 22:41:56]

Description was changed from

==========
Add FPDF_FreeDefaultSystemFontInfo API

Added method that will cast into FPDF_SYSFONTINFO_DEFAULT and delete.
This will allow using FPDF_GetDefaultSystemFontInfo() without memory
management problems.
==========

to

==========
Add FPDF_FreeDefaultSystemFontInfo API

Added method that will cast into FPDF_SYSFONTINFO_DEFAULT and delete.
This will allow using FPDF_GetDefaultSystemFontInfo() without memory
management problems.
==========

[npm, 2016-11-08 22:41:56]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, tsepez@chromium.org

[Tom Sepez, 2016-11-08 22:45:05]

lgtm

https://codereview.chromium.org/2485283002/diff/1/fpdfsdk/fpdf_sysfontinfo.cpp
File fpdfsdk/fpdf_sysfontinfo.cpp (right):

https://codereview.chromium.org/2485283002/diff/1/fpdfsdk/fpdf_sysfontinfo.cp...
fpdfsdk/fpdf_sysfontinfo.cpp:200: auto* pDefault =
static_cast<FPDF_SYSFONTINFO_DEFAULT*>(pDefaultFontInfo);
nit: local not needed, just delete static_cast ...

[npm, 2016-11-08 22:49:37]

https://codereview.chromium.org/2485283002/diff/1/fpdfsdk/fpdf_sysfontinfo.cpp
File fpdfsdk/fpdf_sysfontinfo.cpp (right):

https://codereview.chromium.org/2485283002/diff/1/fpdfsdk/fpdf_sysfontinfo.cp...
fpdfsdk/fpdf_sysfontinfo.cpp:200: auto* pDefault =
static_cast<FPDF_SYSFONTINFO_DEFAULT*>(pDefaultFontInfo);
On 2016/11/08 22:45:05, Tom Sepez wrote:
> nit: local not needed, just delete static_cast ...

Done.

[npm, 2016-11-08 22:49:41]

The CQ bit was checked by npm@chromium.org

[npm, 2016-11-08 22:49:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2485283002/#ps20001
(title: "Nit")

[commit-bot: I haz the power, 2016-11-08 22:49:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:48:40]

Description was changed from

==========
Add FPDF_FreeDefaultSystemFontInfo API

Added method that will cast into FPDF_SYSFONTINFO_DEFAULT and delete.
This will allow using FPDF_GetDefaultSystemFontInfo() without memory
management problems.
==========

to

==========
Add FPDF_FreeDefaultSystemFontInfo API

Added method that will cast into FPDF_SYSFONTINFO_DEFAULT and delete.
This will allow using FPDF_GetDefaultSystemFontInfo() without memory
management problems.

Committed:
https://pdfium.googlesource.com/pdfium/+/788217d77c9933614efbd778b6f6ee0008f4...
==========

[commit-bot: I haz the power, 2016-11-09 00:48:41]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/788217d77c9933614efbd778b6f6ee0008f4...