url/gurl.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/gurl.cc

diff --git a/url/gurl.cc b/url/gurl.cc

index 98a0300216c2ea95e95791075077db4579cc00cb..bdd35227b0dadbd36024a12aa5f51799c189ec06 100644

--- a/url/gurl.cc

+++ b/url/gurl.cc

@@ -512,6 +512,7 @@ bool operator!=(const GURL& x, const GURL& y) {

}

bool operator==(const GURL& x, const base::StringPiece& spec) {

+ DCHECK_EQ(GURL(spec).possibly_invalid_spec(), spec);

return x.possibly_invalid_spec() == spec;

}

« no previous file with comments | « ios/chrome/browser/history/history_utils.cc ('k') | no next file » | no next file with comments »