content/renderer/render_frame_impl.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 2f37f8f8fb98276966d5b8ad5e8d6bddca787974..8a0a4c64c8d2fd3a798bc3a10f9ab4ed697c4e79 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -5144,7 +5144,7 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(

if (iter != parent->history_subframe_unique_names_.end()) {

bool history_item_is_about_blank = iter->second;

should_ask_browser =

- !history_item_is_about_blank || url != GURL(url::kAboutBlankURL);

+ !history_item_is_about_blank || url != url::kAboutBlankURL;

parent->history_subframe_unique_names_.erase(frame_->uniqueName().utf8());

}

« no previous file with comments | « content/public/common/url_constants.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »