content/browser/quota/quota_manager_unittest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/quota/quota_manager_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/quota/quota_manager_unittest.cc

diff --git a/content/browser/quota/quota_manager_unittest.cc b/content/browser/quota/quota_manager_unittest.cc

index 0080f611bfed840596f88d04f40cd9305a4e323a..580d68e059909c783bf9ef033e6479dac485abed 100644

--- a/content/browser/quota/quota_manager_unittest.cc

+++ b/content/browser/quota/quota_manager_unittest.cc

@@ -1490,8 +1490,7 @@ TEST_F(QuotaManagerTest, EvictOriginDataWithDeletionError) {

for (iterator itr(origin_info_entries().begin()),

end(origin_info_entries().end());

itr != end; ++itr) {

- if (itr->type == kTemp &&

- GURL("http://foo.com/") == itr->origin) {

+ if (itr->type == kTemp && itr->origin == "http://foo.com/") {

found_origin_in_database = true;

break;

}