components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

diff --git a/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc b/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

index 837f1e639c6295b34a84dfdb9ef5c009468bbef5..5ee8361d40c00fe9f979023cd0fc0b2d35e940f0 100644

--- a/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

+++ b/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

@@ -165,7 +165,7 @@ class ManagedBookmarksTrackerTest : public testing::Test {

}

} else if (node->is_url()) {

std::string url;

- if (!dict->GetString("url", &url) || node->url() != GURL(url))

+ if (!dict->GetString("url", &url) || node->url() != url)

return false;

} else {

return false;