Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: android_webview/browser/aw_permission_manager_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_permission_manager_unittest.cc
diff --git a/android_webview/browser/aw_permission_manager_unittest.cc b/android_webview/browser/aw_permission_manager_unittest.cc
index e965164ca52eecc790f9cf4671b2b84b3c343c9d..691c4518f6fbdab935016dc18e345d4cc97989ef 100644
--- a/android_webview/browser/aw_permission_manager_unittest.cc
+++ b/android_webview/browser/aw_permission_manager_unittest.cc
@@ -28,9 +28,9 @@ int kNoPendingOperation = -1;
int kRenderProcessIDForTesting = 8;
int kRenderFrameIDForTesting = 19;
-const char kEmbeddingOrigin[] = "https://www.google.com";
-const char kRequestingOrigin1[] = "https://www.google.com";
-const char kRequestingOrigin2[] = "https://www.chromium.org";
+const char kEmbeddingOrigin[] = "https://www.google.com/";
+const char kRequestingOrigin1[] = "https://www.google.com/";
+const char kRequestingOrigin2[] = "https://www.chromium.org/";
class AwBrowserPermissionRequestDelegateForTesting
: public AwBrowserPermissionRequestDelegate {
@@ -39,7 +39,7 @@ class AwBrowserPermissionRequestDelegateForTesting
PermissionType type,
bool grant) {
for (auto it = request_.begin(); it != request_.end(); ++it) {
- if ((*it)->type != type || (*it)->origin != GURL(origin))
+ if ((*it)->type != type || (*it)->origin != origin)
continue;
const base::Callback<void(bool)> callback = (*it)->callback;
request_.erase(it);
« no previous file with comments | « no previous file | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698