Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: content/renderer/render_view_browsertest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <tuple> 7 #include <tuple>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 1727 matching lines...) Expand 10 before | Expand all | Expand 10 after
1738 1738
1739 RenderFrameImpl* frame() { 1739 RenderFrameImpl* frame() {
1740 return static_cast<RenderFrameImpl*>(view()->GetMainRenderFrame()); 1740 return static_cast<RenderFrameImpl*>(view()->GetMainRenderFrame());
1741 } 1741 }
1742 1742
1743 private: 1743 private:
1744 class TestContentRendererClient : public ContentRendererClient { 1744 class TestContentRendererClient : public ContentRendererClient {
1745 public: 1745 public:
1746 bool ShouldSuppressErrorPage(RenderFrame* render_frame, 1746 bool ShouldSuppressErrorPage(RenderFrame* render_frame,
1747 const GURL& url) override { 1747 const GURL& url) override {
1748 return url == GURL("http://example.com/suppress"); 1748 return url == "http://example.com/suppress";
1749 } 1749 }
1750 1750
1751 void GetNavigationErrorStrings(content::RenderFrame* render_frame, 1751 void GetNavigationErrorStrings(content::RenderFrame* render_frame,
1752 const blink::WebURLRequest& failed_request, 1752 const blink::WebURLRequest& failed_request,
1753 const blink::WebURLError& error, 1753 const blink::WebURLError& error,
1754 std::string* error_html, 1754 std::string* error_html,
1755 base::string16* error_description) override { 1755 base::string16* error_description) override {
1756 if (error_html) 1756 if (error_html)
1757 *error_html = "A suffusion of yellow."; 1757 *error_html = "A suffusion of yellow.";
1758 } 1758 }
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
2489 ExpectPauseAndResume(3); 2489 ExpectPauseAndResume(3);
2490 blink::WebScriptSource source2( 2490 blink::WebScriptSource source2(
2491 WebString::fromUTF8("function func2() { func1(); }; func2();")); 2491 WebString::fromUTF8("function func2() { func1(); }; func2();"));
2492 frame()->GetWebFrame()->executeScriptInIsolatedWorld(17, &source2, 1, 1); 2492 frame()->GetWebFrame()->executeScriptInIsolatedWorld(17, &source2, 1, 1);
2493 2493
2494 EXPECT_FALSE(IsPaused()); 2494 EXPECT_FALSE(IsPaused());
2495 Detach(); 2495 Detach();
2496 } 2496 }
2497 2497
2498 } // namespace content 2498 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/data/dom_storage/webcore_test_database.localstorage » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698