Do not run Android management check for re-auth case.

chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 114 matching lines @@
 TEST_F(ArcAuthServiceTest, PrefChangeTriggersService) {
   ASSERT_EQ(ArcAuthService::State::NOT_INITIALIZED, auth_service()->state());
 
   PrefService* const pref = profile()->GetPrefs();
   ASSERT_FALSE(pref->GetBoolean(prefs::kArcEnabled));
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
   ASSERT_EQ(ArcAuthService::State::STOPPED, auth_service()->state());
 
   pref->SetBoolean(prefs::kArcEnabled, true);
-  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
+            auth_service()->state());
 
   pref->SetBoolean(prefs::kArcEnabled, false);
   ASSERT_EQ(ArcAuthService::State::STOPPED, auth_service()->state());
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, DisabledForEphemeralDataUsers) {
   PrefService* const prefs = profile()->GetPrefs();
@@ skipping 42 matching lines @@
   ASSERT_EQ(std::string(), auth_service()->GetAndResetAuthCode());
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
 
   // By default ARC is not enabled.
   ASSERT_EQ(ArcAuthService::State::STOPPED, auth_service()->state());
 
   profile()->GetPrefs()->SetBoolean(prefs::kArcEnabled, true);
 
   // Setting profile and pref initiates a code fetching process.
-  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
+            auth_service()->state());
 
+  // TODO(hidehiko): Verify state transition from SHOWINING_TERMS_OF_SERVICE ->
+  // CHECKING_ANDROID_MANAGEMENT -> FETCHING_CODE, when we extract
+  // ArcSessionManager.
   auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
 
   ASSERT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   ASSERT_TRUE(bridge_service()->ready());
   // Auth code valid only for one call.
   ASSERT_EQ(kTestAuthCode, auth_service()->GetAndResetAuthCode());
   ASSERT_EQ(std::string(), auth_service()->GetAndResetAuthCode());
 
   auth_service()->Shutdown();
   ASSERT_EQ(ArcAuthService::State::NOT_INITIALIZED, auth_service()->state());
   ASSERT_FALSE(bridge_service()->ready());
   ASSERT_EQ(std::string(), auth_service()->GetAndResetAuthCode());
 
   // Send profile and don't provide a code.
   auth_service()->OnPrimaryUserProfilePrepared(profile());
 
   // Setting profile initiates a code fetching process.
-  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
+            auth_service()->state());
 
   content::BrowserThread::GetBlockingPool()->FlushForTesting();
   base::RunLoop().RunUntilIdle();
 
   // UI is disabled in unit tests and this code is unchanged.
-  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
+            auth_service()->state());
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, CancelFetchingDisablesArc) {
   PrefService* const pref = profile()->GetPrefs();
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
   pref->SetBoolean(prefs::kArcEnabled, true);
-  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
+            auth_service()->state());
 
   auth_service()->CancelAuthCode();
   ASSERT_EQ(ArcAuthService::State::STOPPED, auth_service()->state());
   ASSERT_FALSE(pref->GetBoolean(prefs::kArcEnabled));
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, CloseUIKeepsArcEnabled) {
@@ skipping 28 matching lines @@
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, SignInStatus) {
   PrefService* const prefs = profile()->GetPrefs();
 
   EXPECT_FALSE(prefs->GetBoolean(prefs::kArcSignedIn));
   prefs->SetBoolean(prefs::kArcEnabled, true);
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
-  EXPECT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  EXPECT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
+            auth_service()->state());
   auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
   EXPECT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   EXPECT_TRUE(bridge_service()->ready());
   EXPECT_FALSE(prefs->GetBoolean(prefs::kArcSignedIn));
   auth_service()->OnSignInComplete();
   EXPECT_TRUE(prefs->GetBoolean(prefs::kArcSignedIn));
   EXPECT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   EXPECT_TRUE(bridge_service()->ready());
 
   // Second start, no fetching code is expected.
@@ skipping 65 matching lines @@
   second_profile->GetPrefs()->SetBoolean(prefs::kArcEnabled, true);
 
   // Check that non-primary user can't use Arc.
   EXPECT_FALSE(chromeos::ProfileHelper::IsPrimaryProfile(second_profile.get()));
   EXPECT_FALSE(ArcAppListPrefs::Get(second_profile.get()));
 
   auth_service()->Shutdown();
 }
 
 }  // namespace arc