Do not run Android management check for re-auth case.

chrome/browser/chromeos/arc/arc_auth_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_AUTH_SERVICE_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_AUTH_SERVICE_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 41 matching lines @@
                        public mojom::AuthHost,
                        public ArcBridgeService::Observer,
                        public InstanceHolder<mojom::AuthInstance>::Observer,
                        public ArcSupportHost::Observer,
                        public ArcOptInPreferenceHandlerObserver,
                        public ArcAuthContextDelegate,
                        public ArcAuthCodeFetcherDelegate,
                        public sync_preferences::PrefServiceSyncableObserver,
                        public sync_preferences::SyncedPrefObserver {
  public:
   enum class State {

[Luis Héctor Chávez, 2016/11/10 23:30:58]

Can you add a state transition diagram here similar to what we have in ABS?

[hidehiko, 2016/11/14 10:55:09]

Done.

-    NOT_INITIALIZED,  // Service is not initialized.
-    STOPPED,          // ARC is not running.
-    FETCHING_CODE,    // ARC may be running or not. Auth code is fetching.
-    ACTIVE,           // ARC is running.
+    NOT_INITIALIZED,           // Service is not initialized.
+    STOPPED,                   // ARC is not running.
+    TERMS,                     // Showing "Terms Of Service" to user.

[Mr4D (OOO till 08-26), 2016/11/10 16:12:30]

Could TERMS be replaced with something more expressive like "SHOW_TOS" - or if
length doesn't matter "SHOW_TERMS_OF_SERVICE"?

[Luis Héctor Chávez, 2016/11/10 23:30:58]

Also, let's try to use a convention of using present participle for async
operations (-ing suffix, AuthService is currently XXX) and past participle (-ed
suffix)/adjective (AuthService is XXX) for steady states.

so can you please change the state names to SHOWING_TERMS_OF_SERVICE and
CHECKING_ANDROID_MANAGEMENT?

[hidehiko, 2016/11/14 10:55:09]

Done.

+    ANDROID_MANAGEMENT_CHECK,  // Checkng Android management status.

[Luis Héctor Chávez, 2016/11/10 23:30:58]

nit: s/Checkng/Checking/

[hidehiko, 2016/11/14 10:55:09]

Done.

+    FETCHING_CODE,             // ARC is not yet running. Fetching auth token.
+    ACTIVE,                    // ARC is running.
   };
 
   class Observer {
    public:
     virtual ~Observer() = default;
 
     // Called to notify that ARC bridge is shut down.
     virtual void OnShutdownBridge() {}
 
     // Called to notify that ARC enabled state has been updated.
@@ skipping 99 matching lines @@
   // ArcAuthCodeFetcherDelegate:
   void OnAuthCodeSuccess(const std::string& auth_code) override;
   void OnAuthCodeFailed() override;
 
   // ArcSupportHost::Observer:
   void OnWindowClosed() override;
   void OnTermsAgreed(bool is_metrics_enabled,
                      bool is_backup_and_restore_enabled,
                      bool is_location_service_enabled) override;
   void OnAuthSucceeded(const std::string& auth_code) override;
+  void OnRetryClicked() override;
   void OnSendFeedbackClicked() override;
 
   // arc::ArcOptInPreferenceHandlerObserver:
   void OnMetricsModeChanged(bool enabled, bool managed) override;
   void OnBackupAndRestoreModeChanged(bool enabled, bool managed) override;
   void OnLocationServicesModeChanged(bool enabled, bool managed) override;
 
   // Stops ARC without changing ArcEnabled preference.
   void StopArc();
 
@@ skipping 23 matching lines @@
   void ShowUI(ArcSupportHost::UIPage page, const base::string16& status);
   void CloseUI();
   void SetUIPage(ArcSupportHost::UIPage page, const base::string16& status);
   void SetState(State state);
   void ShutdownBridge();
   void ShutdownBridgeAndCloseUI();
   void ShutdownBridgeAndShowUI(ArcSupportHost::UIPage page,
                                const base::string16& status);
   void OnOptInPreferenceChanged();
   void StartUI();
-  void StartAndroidManagementClient();

[hidehiko, 2016/11/10 01:46:23]

Note: No implemention. No usage...

   void OnAndroidManagementPassed();
   void OnArcDataRemoved(bool success);
   void OnArcSignInTimeout();
   bool IsAuthCodeRequest() const;
   void FetchAuthCode();
   void PrepareContextForAuthCodeRequest();
   void RequestAccountInfoInternal(
       std::unique_ptr<AccountInfoNotifier> account_info_notifier);
   void OnAccountInfoReady(mojom::AccountInfoPtr account_info);
 
+  void StartArcAndroidManagementCheck();
+
   // Called when the Android management check is done in opt-in flow or
   // re-auth flow.
   void OnAndroidManagementChecked(
       policy::AndroidManagementClient::Result result);
 
   // Called when the background Android management check is done. It is
   // triggered when the second or later ARC boot timing.
   void OnBackgroundAndroidManagementChecked(
       policy::AndroidManagementClient::Result result);
 
@@ skipping 34 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ArcAuthService);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os, const ArcAuthService::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_AUTH_SERVICE_H_