[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and GetHeaderValue

[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors were from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/ca44a7a790a7f94f67742aee6b2e330f762d6cae
Cr-Commit-Position: refs/heads/master@{#432085}

[chanpatorikku, 2016-11-10 11:34:35]

Description was changed from

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors are from fake_pepper_interface_url_loader*
and fake_util*.
==========

to

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors are from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-10 11:34:36]

chanpatorikku@gmail.com changed reviewers:
+ binji@chromium.org, sbc@chromium.org

[chanpatorikku, 2016-11-10 11:35:04]

Description was changed from

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors are from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors were from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-10 13:54:06]

ptal.

[chanpatorikku, 2016-11-14 13:54:13]

Modifying 1 out of about 30 lines in GetHeaderValue and not commenting what had
been modified was not very friendly for reviews.  A comment was added for making
the patch set more friendly to review.  ptal.

https://codereview.chromium.org/2485203005/diff/1/native_client_sdk/src/tests...
File native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_util.cc (right):

https://codereview.chromium.org/2485203005/diff/1/native_client_sdk/src/tests...
native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_util.cc:48: offset =
newline + 1;
Can we make this allow multiple newlines in "headers"?

The only modification of "GetHeaderValue" is to modify from "offset = newline;"
to "offset = newline + 1;".  When "offset" is equal to an index of '\n',
"headers.find('\n', offset)" returns the value of "offset".

[binji, 2016-11-14 22:52:31]

lgtm

https://codereview.chromium.org/2485203005/diff/1/native_client_sdk/src/tests...
File native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_util.cc (right):

https://codereview.chromium.org/2485203005/diff/1/native_client_sdk/src/tests...
native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_util.cc:48: offset =
newline + 1;
On 2016/11/14 13:54:13, chanpatorikku wrote:
> Can we make this allow multiple newlines in "headers"?
> 
> The only modification of "GetHeaderValue" is to modify from "offset =
newline;"
> to "offset = newline + 1;".  When "offset" is equal to an index of '\n',
> "headers.find('\n', offset)" returns the value of "offset".

Yes, I think this should be newline + 1.

[chanpatorikku, 2016-11-15 02:39:32]

The CQ bit was checked by chanpatorikku@gmail.com

[commit-bot: I haz the power, 2016-11-15 02:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:52:08]

Description was changed from

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors were from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors were from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[commit-bot: I haz the power, 2016-11-15 03:52:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-15 03:53:54]

Description was changed from

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors were from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue

Move FakeURLRequestInfoResource, FakeURLResponseInfoResource, and
GetHeaderValue from fake_pepper_interface_url_loader.cc to
fake_util.{cc,h} to share the code with the future code.

Modify slightly on the implementation of GetHeaderValue.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

test_sdk.py was run. Unit tests passed on all platforms.
Not any compiler errors were from fake_pepper_interface_url_loader*
and fake_util*.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/ca44a7a790a7f94f67742aee6b2e330f762d6cae
Cr-Commit-Position: refs/heads/master@{#432085}
==========

[commit-bot: I haz the power, 2016-11-15 03:53:55]

Patchset 1 (id:??) landed as
https://crrev.com/ca44a7a790a7f94f67742aee6b2e330f762d6cae
Cr-Commit-Position: refs/heads/master@{#432085}