Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2485203002: Revert of Fix link's hover state if the link under scrollbar (Closed)

Created:
4 years, 1 month ago by bokan
Modified:
4 years, 1 month ago
Reviewers:
chaopeng
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix link's hover state if the link under scrollbar (patchset #10 id:180001 of https://codereview.chromium.org/2389073002/ ) Reason for revert: Due to crbug.com/662402, need to revert crrev.com/2467693002 which this depends on. I'll reland when the dust settles. Original issue's description: > Fix link's hover state if the link under scrollbar > > In this patch, we check the hitTest includes scrollbar in > ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement, > Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent > showing url, tooltip and hand cursor when mouse move on the link under scrollbar > or showing active state when mouse click on the link under scrollbar. > > BUG=636436 > > Committed: https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053 > Cr-Commit-Position: refs/heads/master@{#430141} TBR=chaopeng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636436 Committed: https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4 Cr-Commit-Position: refs/heads/master@{#430717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -154 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 7 chunks +10 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +0 lines, -103 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bokan
Created Revert of Fix link's hover state if the link under scrollbar
4 years, 1 month ago (2016-11-08 17:11:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485203002/1
4 years, 1 month ago (2016-11-08 17:11:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:29:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4 Cr-Commit-Position: refs/heads/master@{#430717}
4 years, 1 month ago (2016-11-08 21:38:39 UTC) #6
bokan
4 years, 1 month ago (2016-11-11 19:03:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2491953004/ by bokan@chromium.org.

The reason for reverting is: Relanding now that crrev.com/2467693002 has been
relanded..

Powered by Google App Engine
This is Rietveld 408576698