Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2485163003: [heap] Use right BodyDescriptor for JSWeakCollection (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use right BodyDescriptor for JSWeakCollection Workes by accident when using the JSObject descriptor as it also implements strong semantics. BUG=chromium:651354 Committed: https://crrev.com/f51b7eddf382f84d10dc02a9378bf26d27624b2c Cr-Commit-Position: refs/heads/master@{#40842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
4 years, 1 month ago (2016-11-08 14:56:31 UTC) #3
ulan
lgtm
4 years, 1 month ago (2016-11-08 15:02:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485163003/1
4 years, 1 month ago (2016-11-08 15:26:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 15:28:30 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f51b7eddf382f84d10dc02a9378bf26d27624b2c
Cr-Commit-Position: refs/heads/master@{#40842}

Powered by Google App Engine
This is Rietveld 408576698