Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2485093003: dart2js: depend directly on kernel/ast to avoid indirect dependency on dart:io (Closed)

Created:
4 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: depend directly on kernel/ast to avoid indirect dependency on dart:io BUG= https://github.com/dart-lang/sdk/issues/27744 R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/ce758e7e0a55ef1e68a85668fe9a85bc3a25bc97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/lib/src/kernel/kernel_debug.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
4 years, 1 month ago (2016-11-08 21:12:34 UTC) #2
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-08 21:12:58 UTC) #3
Siggi Cherem (dart-lang)
4 years, 1 month ago (2016-11-08 21:13:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce758e7e0a55ef1e68a85668fe9a85bc3a25bc97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698