Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2485063004: Rename getDIPScale() to getDipScale() (Closed)

Created:
4 years, 1 month ago by Tima Vaisburd
Modified:
4 years, 1 month ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename getDIPScale() to getDipScale() Rename the method to comply to Java code guidelines. BUG=625089 Committed: https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974 Cr-Commit-Position: refs/heads/master@{#430733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Tima Vaisburd
As promised, and sorry for the delay. PTAL.
4 years, 1 month ago (2016-11-08 21:03:39 UTC) #7
boliu
lgtm
4 years, 1 month ago (2016-11-08 21:19:52 UTC) #8
Ted C
On 2016/11/08 21:19:52, boliu wrote: > lgtm lgtm
4 years, 1 month ago (2016-11-08 21:40:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485063004/1
4 years, 1 month ago (2016-11-08 22:01:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 22:07:23 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 22:24:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974
Cr-Commit-Position: refs/heads/master@{#430733}

Powered by Google App Engine
This is Rietveld 408576698