Fix a failing service worker startup test to work with mojo IPC

Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently simulates a Stopped IPC via chromium IPC when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701
Committed: https://crrev.com/6545fae393ddfb4d2adbb685b1442cb90f6c7ff8
Cr-Commit-Position: refs/heads/master@{#430870}

[shimazu, 2016-11-08 05:41:21]

Description was changed from

==========
Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently sends Stopped IPC using chromium IPC when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701
==========

to

==========
Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently simulates a Stopped IPC via chromium IPC
when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701
==========

[shimazu, 2016-11-08 05:42:42]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org

[shimazu, 2016-11-08 05:42:42]

ptal

[horo, 2016-11-08 07:30:12]

https://codereview.chromium.org/2485053002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version_unittest.cc (right):

https://codereview.chromium.org/2485053002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version_unittest.cc:354: return
base::MakeUnique<MessageReceiverDisallowStart>();
You can set is_mojo_enabled in the constructor of MessageReceiverDisallowStart.

return base::MakeUnique<MessageReceiverDisallowStart>(is_mojo_enabled());

[shimazu, 2016-11-09 02:23:37]

Updated. ptal again.

https://codereview.chromium.org/2485053002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version_unittest.cc (right):

https://codereview.chromium.org/2485053002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version_unittest.cc:354: return
base::MakeUnique<MessageReceiverDisallowStart>();
On 2016/11/08 07:30:12, horo wrote:
> You can set is_mojo_enabled in the constructor of
MessageReceiverDisallowStart.
> 
> return base::MakeUnique<MessageReceiverDisallowStart>(is_mojo_enabled());

Done.

[horo, 2016-11-09 03:22:09]

lgtm

[shimazu, 2016-11-09 03:23:41]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2016-11-09 03:24:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 05:21:51]

Description was changed from

==========
Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently simulates a Stopped IPC via chromium IPC
when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701
==========

to

==========
Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently simulates a Stopped IPC via chromium IPC
when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701
==========

[commit-bot: I haz the power, 2016-11-09 05:21:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 05:26:35]

Description was changed from

==========
Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently simulates a Stopped IPC via chromium IPC
when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701
==========

to

==========
Fix a failing service worker startup test to work with mojo IPC

MessageReceiverDisallowStart currently simulates a Stopped IPC via chromium IPC
when
StartMode is set to FAIL though mojo is enabled. This patch changes the behavior
to resetting a MockEmbeddedWorkerInstanceClient. This triggers a mojo error
handler and ServiceWorkerVersion will go to the stop sequence.

BUG=629701

Committed: https://crrev.com/6545fae393ddfb4d2adbb685b1442cb90f6c7ff8
Cr-Commit-Position: refs/heads/master@{#430870}
==========

[commit-bot: I haz the power, 2016-11-09 05:26:36]

Patchset 2 (id:??) landed as
https://crrev.com/6545fae393ddfb4d2adbb685b1442cb90f6c7ff8
Cr-Commit-Position: refs/heads/master@{#430870}