Don't serialize elements of top-level function/constructor/method bodies.

Don't serialize elements of top-level function/constructor/method bodies.

Instead in DeclarationResolver build these local elements in the bodies.

As you can see, the summary_common tests are quite ugly now, we decided
that we still have to serialize everything in variable initialiers,
including local functions. So, this requires repurposing the tests to
using initializers, and also keep buildLabelElements() in
DeclarationResolver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e7350d171e92d8e630da6cebbeeae5887991e13d

[Paul Berry, 2016-11-08 20:47:02]

lgtm

https://codereview.chromium.org/2485043004/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2485043004/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1463: //    UnlinkedExecutable
executable =
Remove commented out code.

[Brian Wilkerson, 2016-11-08 21:12:08]

lgtm

https://codereview.chromium.org/2485043004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/declaration_resolver.dart (right):

https://codereview.chromium.org/2485043004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/declaration_resolver.dart:228:
_walker._elementHolder.addFunction(element);
Is it true that the holder can't be null here but can be null on line 214?

[scheglov, 2016-11-09 03:11:36]

https://codereview.chromium.org/2485043004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/declaration_resolver.dart (right):

https://codereview.chromium.org/2485043004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/declaration_resolver.dart:228:
_walker._elementHolder.addFunction(element);
On 2016/11/08 21:12:08, Brian Wilkerson wrote:
> Is it true that the holder can't be null here but can be null on line 214?

Yes, I think so.
We create ElementHolder only when we visit an ExecutableElement.
And FunctionExpression(s) can only be used where Expression(s) can be used - in
method bodies or variable initializers.

[scheglov, 2016-11-09 03:19:51]

Description was changed from

==========
Don't serialize elements of top-level function/constructor/method bodies.

Instead in DeclarationResolver build these local elements in the bodies.

As you can see, the summary_common tests are quite ugly now, we decided
that we still have to serialize everything in variable initialiers,
including local functions. So, this requires repurposing the tests to
using initializers, and also keep buildLabelElements() in
DeclarationResolver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Don't serialize elements of top-level function/constructor/method bodies.

Instead in DeclarationResolver build these local elements in the bodies.

As you can see, the summary_common tests are quite ugly now, we decided
that we still have to serialize everything in variable initialiers,
including local functions. So, this requires repurposing the tests to
using initializers, and also keep buildLabelElements() in
DeclarationResolver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e7350d171e92d8e630da6cebbeeae5887991e13d
==========

[scheglov, 2016-11-09 03:19:53]

Committed patchset #1 (id:1) manually as
e7350d171e92d8e630da6cebbeeae5887991e13d (presubmit successful).