Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2485033002: X87: [turbofan] Refactor the compare-zero folding in instruction selector. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Refactor the compare-zero folding in instruction selector. port 9b308dcaf5ce0597a2acfd85d7104ed263c472aa (r40721) original commit message: BUG= Committed: https://crrev.com/db7580a4950b9bbfde59180ca9ec56355f71153f Cr-Commit-Position: refs/heads/master@{#40818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-08 02:32:08 UTC) #2
Weiliang
lgtm
4 years, 1 month ago (2016-11-08 02:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485033002/1
4 years, 1 month ago (2016-11-08 03:12:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 03:32:31 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db7580a4950b9bbfde59180ca9ec56355f71153f
Cr-Commit-Position: refs/heads/master@{#40818}

Powered by Google App Engine
This is Rietveld 408576698