Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2485013002: Reland of Clean up some NativeTheme code. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
bokan, sky
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Clean up some NativeTheme code. ( https://codereview.chromium.org/2480993002/ ) Now with appropriate use of break in switch statement. Original issue's description: > Clean up some NativeTheme code. > > - improve instantiation > - allow to specify separate instances for web and native > - two NativeThemeAura instances coexist for w/wo overlay scrollbars > > BUG=307091 Committed: https://crrev.com/93ed99a0238f25fe391874d3f6dfa02c01acb781 Cr-Commit-Position: refs/heads/master@{#430608}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -42 lines) Patch
M ui/native_theme/native_theme.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_aura.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.cc View 6 chunks +44 lines, -32 lines 1 comment Download
M ui/native_theme/native_theme_dark_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Evan Stade
https://codereview.chromium.org/2485013002/diff/1/ui/native_theme/native_theme_aura.cc File ui/native_theme/native_theme_aura.cc (right): https://codereview.chromium.org/2485013002/diff/1/ui/native_theme/native_theme_aura.cc#newcode205 ui/native_theme/native_theme_aura.cc:205: break; these breaks were missing from the first patch.
4 years, 1 month ago (2016-11-08 01:42:29 UTC) #3
Evan Stade
4 years, 1 month ago (2016-11-08 01:42:33 UTC) #5
bokan
lgtm
4 years, 1 month ago (2016-11-08 03:29:28 UTC) #8
sky
LGTM
4 years, 1 month ago (2016-11-08 05:06:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485013002/1
4 years, 1 month ago (2016-11-08 14:25:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 14:33:25 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2fd274ec5b20ace720420106a13b8c90b61bed1 Cr-Commit-Position: refs/heads/master@{#430607}
4 years, 1 month ago (2016-11-08 14:36:07 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/93ed99a0238f25fe391874d3f6dfa02c01acb781 Cr-Commit-Position: refs/heads/master@{#430608}
4 years, 1 month ago (2016-11-08 14:36:09 UTC) #16
findit-for-me
FYI: Findit identified this CL at revision 430608 as the culprit for failures in the ...
4 years, 1 month ago (2016-11-08 14:47:20 UTC) #17
xlai (Olivia)
4 years, 1 month ago (2016-11-08 14:48:54 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2484973003/ by xlai@chromium.org.

The reason for reverting is: Apparently CQ landed this CL twice. Tried reverting
it once to see what happens..

Powered by Google App Engine
This is Rietveld 408576698