Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2484973005: [Blink, RemotePlaybackAPI] Create WebRemotePlaybackClient in HTMLMediaElement ctor to avoid lazy in… (Closed)
Patch Set: Removed m_scriptState from RemotePlayback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index be3968b5e56dd5f10eacdd3546f0864afe956048..c91a76936a78f4f352f125011fc1b9a8f8bae2d1 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -96,6 +96,7 @@
#include "wtf/PtrUtil.h"
#include "wtf/text/CString.h"
#include <limits>
+#include <v8.h>
haraken 2016/11/09 02:46:41 Remove this.
whywhat 2016/11/09 03:06:37 Done.
#ifndef BLINK_MEDIA_LOG
#define BLINK_MEDIA_LOG DVLOG(3)
@@ -475,6 +476,12 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName,
m_lockedPendingUserGesture = true;
}
+ LocalFrame* frame = document.frame();
+ if (frame) {
+ m_remotePlaybackClient =
+ frame->loader().client()->createWebRemotePlaybackClient(*this);
+ }
+
setHasCustomStyleCallbacks();
addElementToDocumentMap(this, &document);
@@ -3939,11 +3946,6 @@ void HTMLMediaElement::updatePositionNotificationRegistration() {
m_autoplayHelper->updatePositionNotificationRegistration();
}
-void HTMLMediaElement::setRemotePlaybackClient(
- WebRemotePlaybackClient* client) {
- m_remotePlaybackClient = client;
-}
-
// TODO(liberato): remove once autoplay gesture override experiment concludes.
void HTMLMediaElement::triggerAutoplayViewportCheckForTesting() {
if (FrameView* view = document().view())

Powered by Google App Engine
This is Rietveld 408576698