chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm - Issue 2484973004: [Mac] Refactor Immersive Fullscreen Logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm

Issue 2484973004: [Mac] Refactor Immersive Fullscreen Logic (Closed)

Patch Set: fix for rsesek Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm

diff --git a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm b/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm

index d40ea7b176a978c619e305503543ae680860c6a1..7e4a63586b98d820c7cd9ef34552865cce75afcf 100644

--- a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm

+++ b/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm

@@ -108,12 +108,7 @@ initWithFullscreenToolbarController:(FullscreenToolbarController*)owner

}

- (BOOL)mouseInsideTrackingArea {

- if (!trackingArea_)

- return NO;

- NSPoint mouseLoc = [[contentView_ window] mouseLocationOutsideOfEventStream];

- NSPoint mousePos = [contentView_ convertPoint:mouseLoc fromView:nil];

- return NSMouseInRect(mousePos, trackingAreaFrame_, [contentView_ isFlipped]);

+ return [trackingArea_ mouseInsideTrackingAreaForView:contentView_];

}

- (void)mouseEntered:(NSEvent*)event {