Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2484973003: Revert of Clean up some NativeTheme code. (Closed)

Created:
4 years, 1 month ago by xlai (Olivia)
Modified:
4 years, 1 month ago
Reviewers:
bokan, sky, Evan Stade
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up some NativeTheme code. (patchset #1 id:1 of https://codereview.chromium.org/2485013002/ ) Reason for revert: Apparently CQ landed this CL twice. Tried reverting it once to see what happens. Original issue's description: > Reland of Clean up some NativeTheme code. > ( https://codereview.chromium.org/2480993002/ ) > > Now with appropriate use of break in switch statement. > > Original issue's description: > > Clean up some NativeTheme code. > > > > - improve instantiation > > - allow to specify separate instances for web and native > > - two NativeThemeAura instances coexist for w/wo overlay scrollbars > > > > BUG=307091 > > Committed: https://crrev.com/93ed99a0238f25fe391874d3f6dfa02c01acb781 > Cr-Commit-Position: refs/heads/master@{#430608} TBR=bokan@chromium.org,sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/16a00aca0642af4f75ed4c68f662e68f590c6cef Cr-Commit-Position: refs/heads/master@{#430610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -67 lines) Patch
M ui/native_theme/native_theme.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/native_theme/native_theme_aura.h View 2 chunks +1 line, -4 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 6 chunks +32 lines, -44 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/view.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
xlai (Olivia)
Created Revert of Clean up some NativeTheme code.
4 years, 1 month ago (2016-11-08 14:48:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484973003/1
4 years, 1 month ago (2016-11-08 14:49:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 14:50:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16a00aca0642af4f75ed4c68f662e68f590c6cef Cr-Commit-Position: refs/heads/master@{#430610}
4 years, 1 month ago (2016-11-08 14:53:40 UTC) #6
Evan Stade
4 years, 1 month ago (2016-11-08 14:56:35 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2483823004/ by estade@chromium.org.

The reason for reverting is: wrong CL reverted.

Powered by Google App Engine
This is Rietveld 408576698