core/fpdfdoc/cpdf_formfield.cpp - Issue 2484953003: Force compiler to deduce src type for checked_cast<dst, src>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_formfield.cpp

Issue 2484953003: Force compiler to deduce src type for checked_cast<dst, src>. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_formfield.cpp

diff --git a/core/fpdfdoc/cpdf_formfield.cpp b/core/fpdfdoc/cpdf_formfield.cpp

index e2240c9f2f09fa1583a41193ef8303e6a1c3724d..8170b7fcbf7cceb58752984722c460d2696b0895 100644

--- a/core/fpdfdoc/cpdf_formfield.cpp

+++ b/core/fpdfdoc/cpdf_formfield.cpp

@@ -682,7 +682,7 @@ int CPDF_FormField::InsertOption(CFX_WideString csOptLabel,

m_pDict->SetFor("Opt", pOpt);

}

- int iCount = pdfium::base::checked_cast<int, size_t>(pOpt->GetCount());

+ int iCount = pdfium::base::checked_cast<int>(pOpt->GetCount());

if (index >= iCount) {

pOpt->AddString(csStr);

index = iCount;

« no previous file with comments | « core/fpdfapi/parser/cpdf_parser.cpp ('k') | fpdfsdk/fpdfview.cpp » ('j') | no next file with comments »