Force compiler to deduce src type for checked_cast<dst, src>.

Force compiler to deduce src type for checked_cast<dst, src>.

Otherwise, we might be silently doing an unsafe cast before
applying the check if the actual argument doesn't match the
exact src type.

Committed: https://pdfium.googlesource.com/pdfium/+/4e597c8fd5d604273266ea19a1074a2c870ba224

[Tom Sepez, 2016-11-07 23:00:19]

Description was changed from

==========
Force compiler to deduce src type for checked_cast<>.

Otherwise, we might be silently doing an unsafe cast before
applying the check.
==========

to

==========
Force compiler to deduce src type for checked_cast<>.

Otherwise, we might be silently doing an unsafe cast before
applying the check if the actual argument doesn't match the
exact src type.
==========

[Tom Sepez, 2016-11-07 23:00:19]

tsepez@chromium.org changed reviewers:
+ jschuh@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-11-07 23:00:45]

Lei, quick review of some cleanup Justin discovered.  Thanks.

[Tom Sepez, 2016-11-07 23:00:53]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-07 23:05:14]

Description was changed from

==========
Force compiler to deduce src type for checked_cast<>.

Otherwise, we might be silently doing an unsafe cast before
applying the check if the actual argument doesn't match the
exact src type.
==========

to

==========
Force compiler to deduce src type for checked_cast<dst, src>.

Otherwise, we might be silently doing an unsafe cast before
applying the check if the actual argument doesn't match the
exact src type.
==========

[Lei Zhang, 2016-11-07 23:08:02]

lgtm

[Tom Sepez, 2016-11-07 23:10:29]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-11-07 23:10:34]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:10:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 23:16:04]

Description was changed from

==========
Force compiler to deduce src type for checked_cast<dst, src>.

Otherwise, we might be silently doing an unsafe cast before
applying the check if the actual argument doesn't match the
exact src type.
==========

to

==========
Force compiler to deduce src type for checked_cast<dst, src>.

Otherwise, we might be silently doing an unsafe cast before
applying the check if the actual argument doesn't match the
exact src type.

Committed:
https://pdfium.googlesource.com/pdfium/+/4e597c8fd5d604273266ea19a1074a2c870b...
==========

[commit-bot: I haz the power, 2016-11-07 23:16:05]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4e597c8fd5d604273266ea19a1074a2c870b...