Eliminate quit closure argument to embedded service factories

Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986
Committed: https://crrev.com/e34d2ea2d89e340de75c2670c5e84eb4000b5c43
Cr-Commit-Position: refs/heads/master@{#430470}

[Ken Rockot(use gerrit already), 2016-11-07 22:59:38]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:00:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-07 23:04:07]

Description was changed from

==========
Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986
==========

to

==========
Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986
TBR=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-11-07 23:04:52]

Description was changed from

==========
Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986
TBR=ben@chromium.org
==========

to

==========
Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986
==========

[Ken Rockot(use gerrit already), 2016-11-07 23:05:01]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2016-11-07 23:05:41]

Not really an interesting change, but it falls short of my TBR bar

[Ben Goodger (Google), 2016-11-07 23:22:05]

lgtm

[commit-bot: I haz the power, 2016-11-07 23:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:34:05]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Ken Rockot(use gerrit already), 2016-11-07 23:36:58]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:24:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:24:00]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-11-08 01:25:39]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-08 01:25:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2484953002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-11-08 01:26:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:39:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 01:47:23]

Description was changed from

==========
Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986
==========

to

==========
Eliminate quit closure argument to embedded service factories

Services now have safe, direct access to their ServiceContext and
may therefore explicitly call RequestQuit() on it. This obviates
the need for a quit closure argument.

BUG=654986

Committed: https://crrev.com/e34d2ea2d89e340de75c2670c5e84eb4000b5c43
Cr-Commit-Position: refs/heads/master@{#430470}
==========

[commit-bot: I haz the power, 2016-11-08 01:47:24]

Patchset 2 (id:??) landed as
https://crrev.com/e34d2ea2d89e340de75c2670c5e84eb4000b5c43
Cr-Commit-Position: refs/heads/master@{#430470}