Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2484943005: Whitelist flatc in Linux. (Closed)

Created:
4 years, 1 month ago by Yoshisato Yanagisawa
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist flatc in Linux. Since __DATE__ is used in flatc, compile result sometimes not deterministic. BUG=314403 BUG=330263 Committed: https://crrev.com/54934b6280e5bc3f8a823e6543cab3dbdb304ccb Cr-Commit-Position: refs/heads/master@{#431045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/determinism/compare_build_artifacts.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Yoshisato Yanagisawa
4 years, 1 month ago (2016-11-09 04:29:54 UTC) #2
M-A Ruel
lgtm, updated the CL description to reference the other bug 330263 too.
4 years, 1 month ago (2016-11-09 21:43:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484943005/1
4 years, 1 month ago (2016-11-09 21:43:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 21:58:45 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54934b6280e5bc3f8a823e6543cab3dbdb304ccb Cr-Commit-Position: refs/heads/master@{#431045}
4 years, 1 month ago (2016-11-09 22:02:25 UTC) #10
Dirk Pranke
4 years, 1 month ago (2016-11-10 00:32:44 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698