Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Side by Side Diff: ipc/ipc_channel_nacl.h

Issue 2484943004: Remove unused parts of IPC::ChannelHandle. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_CHANNEL_NACL_H_ 5 #ifndef IPC_IPC_CHANNEL_NACL_H_
6 #define IPC_IPC_CHANNEL_NACL_H_ 6 #define IPC_IPC_CHANNEL_NACL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 bool DidEmptyInputBuffers() override; 68 bool DidEmptyInputBuffers() override;
69 void HandleInternalMessage(const Message& msg) override; 69 void HandleInternalMessage(const Message& msg) override;
70 base::ProcessId GetSenderPID() override; 70 base::ProcessId GetSenderPID() override;
71 71
72 Mode mode_; 72 Mode mode_;
73 bool waiting_connect_; 73 bool waiting_connect_;
74 74
75 // The pipe used for communication. 75 // The pipe used for communication.
76 int pipe_; 76 int pipe_;
77 77
78 // The "name" of our pipe. On Windows this is the global identifier for
79 // the pipe. On POSIX it's used as a key in a local map of file descriptors.
80 // For NaCl, we don't actually support looking up file descriptors by name,
81 // and it's only used for debug information.
82 std::string pipe_name_;
83
84 // We use a thread for reading, so that we can simply block on reading and 78 // We use a thread for reading, so that we can simply block on reading and
85 // post the received data back to the main thread to be properly interleaved 79 // post the received data back to the main thread to be properly interleaved
86 // with other tasks in the MessagePump. 80 // with other tasks in the MessagePump.
87 // 81 //
88 // imc_recvmsg supports non-blocking reads, but there's no easy way to be 82 // imc_recvmsg supports non-blocking reads, but there's no easy way to be
89 // informed when a write or read can be done without blocking (this is handled 83 // informed when a write or read can be done without blocking (this is handled
90 // by libevent in Posix). 84 // by libevent in Posix).
91 std::unique_ptr<ReaderThreadRunner> reader_thread_runner_; 85 std::unique_ptr<ReaderThreadRunner> reader_thread_runner_;
92 std::unique_ptr<base::DelegateSimpleThread> reader_thread_; 86 std::unique_ptr<base::DelegateSimpleThread> reader_thread_;
93 87
(...skipping 22 matching lines...) Expand all
116 std::deque<linked_ptr<Message> > output_queue_; 110 std::deque<linked_ptr<Message> > output_queue_;
117 111
118 base::WeakPtrFactory<ChannelNacl> weak_ptr_factory_; 112 base::WeakPtrFactory<ChannelNacl> weak_ptr_factory_;
119 113
120 DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelNacl); 114 DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelNacl);
121 }; 115 };
122 116
123 } // namespace IPC 117 } // namespace IPC
124 118
125 #endif // IPC_IPC_CHANNEL_NACL_H_ 119 #endif // IPC_IPC_CHANNEL_NACL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698