MojoAsyncResourceHandler: Ignore Resume/OnWritable calls after error.

MojoAsyncResourceHandler:  Ignore Resume/OnWritable calls after error.

If the Resume succeed after an error, we end up in an indeterminant
state, which would be bad.  Uncear if that can happen, but easy to
prevent it.

BUG=663053
Committed: https://crrev.com/f12e05a01aba7dadd32003da6149d0a2f9cd3d52
Cr-Commit-Position: refs/heads/master@{#430582}

[mmenke, 2016-11-07 21:05:44]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 21:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-11-07 21:08:26]

mmenke@chromium.org changed reviewers:
+ yhirano@chromium.org

[mmenke, 2016-11-07 21:08:27]

Does this seem reasonable?

The BeginWriteFailsOnResume and
EndWriteFailsOnResumeWithInsufficientInitialCapicity tests result in cancelling
multiple times because OnWriteable keeps on being called.

Noticed this when refactoring the ResourceHandler stack, working on making it
non-broken in the cancellation case.

[mmenke, 2016-11-07 21:09:34]

On 2016/11/07 21:08:27, mmenke wrote:
> Does this seem reasonable?
> 
> The BeginWriteFailsOnResume and
> EndWriteFailsOnResumeWithInsufficientInitialCapicity tests result in
cancelling
> multiple times because OnWriteable keeps on being called.
> 
> Noticed this when refactoring the ResourceHandler stack, working on making it
> non-broken in the cancellation case.

I wanted to add the unittest one cancel per test EXPECT line, and then ran into
all those extra cancels.

[commit-bot: I haz the power, 2016-11-07 23:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:03:46]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-08 11:45:33]

lgtm, thanks.

[mmenke, 2016-11-08 11:46:36]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:46:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 11:51:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-08 11:53:52]

Description was changed from

==========
MojoAsyncResourceHandler:  Ignore Resume/OnWritable calls after error.

If the Resume succeed after an error, we end up in an indeterminant
state, which would be bad.  Uncear if that can happen, but easy to
prevent it.

BUG=663053
==========

to

==========
MojoAsyncResourceHandler:  Ignore Resume/OnWritable calls after error.

If the Resume succeed after an error, we end up in an indeterminant
state, which would be bad.  Uncear if that can happen, but easy to
prevent it.

BUG=663053

Committed: https://crrev.com/f12e05a01aba7dadd32003da6149d0a2f9cd3d52
Cr-Commit-Position: refs/heads/master@{#430582}
==========

[commit-bot: I haz the power, 2016-11-08 11:53:53]

Patchset 1 (id:??) landed as
https://crrev.com/f12e05a01aba7dadd32003da6149d0a2f9cd3d52
Cr-Commit-Position: refs/heads/master@{#430582}