media/cast/transport/rtp_sender/rtp_sender.cc - Issue 248493002: Cast: Deduplicate packets in paced sender and always send older packets first

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/transport/rtp_sender/rtp_sender.cc

Issue 248493002: Cast: Deduplicate packets in paced sender and always send older packets first (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re-upping to trick build system Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.cc ('k') | media/cast/video_receiver/video_receiver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/transport/rtp_sender/rtp_sender.cc

diff --git a/media/cast/transport/rtp_sender/rtp_sender.cc b/media/cast/transport/rtp_sender/rtp_sender.cc

index f1752855fbeecaf3462ef8dffa0d590d1a884067..9f891193a53c091cc3b2bb0ca7b859331cfb6a49 100644

--- a/media/cast/transport/rtp_sender/rtp_sender.cc

+++ b/media/cast/transport/rtp_sender/rtp_sender.cc

@@ -78,7 +78,7 @@ void RtpSender::ResendPackets(

missing_frames_and_packets.begin();

it != missing_frames_and_packets.end();

++it) {

- PacketList packets_to_resend;

+ SendPacketVector packets_to_resend;

uint8 frame_id = it->first;

const PacketIdSet& packets_set = it->second;

bool success = false;

@@ -96,7 +96,7 @@ void RtpSender::ResendPackets(

VLOG(3) << "Resend " << static_cast<int>(frame_id) << ":"

<< packet_id;

// Set a unique incremental sequence number for every packet.

- PacketRef packet = packets_to_resend.back();

+ PacketRef packet = packets_to_resend.back().second;

UpdateSequenceNumber(&packet->data);

// Set the size as correspond to each frame.

++packet_id;

@@ -114,7 +114,7 @@ void RtpSender::ResendPackets(

if (success) {

VLOG(3) << "Resend " << static_cast<int>(frame_id) << ":"

<< packet_id;

- PacketRef packet = packets_to_resend.back();

+ PacketRef packet = packets_to_resend.back().second;

UpdateSequenceNumber(&packet->data);

}