Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Side by Side Diff: media/cast/audio_receiver/audio_receiver_unittest.cc

Issue 248493002: Cast: Deduplicate packets in paced sender and always send older packets first (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/test/simple_test_tick_clock.h" 8 #include "base/test/simple_test_tick_clock.h"
9 #include "media/cast/audio_receiver/audio_receiver.h" 9 #include "media/cast/audio_receiver/audio_receiver.h"
10 #include "media/cast/cast_defines.h" 10 #include "media/cast/cast_defines.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 113
114 // Important for the AudioReceiver to be declared last, since its dependencies 114 // Important for the AudioReceiver to be declared last, since its dependencies
115 // must remain alive until after its destruction. 115 // must remain alive until after its destruction.
116 scoped_ptr<AudioReceiver> receiver_; 116 scoped_ptr<AudioReceiver> receiver_;
117 }; 117 };
118 118
119 TEST_F(AudioReceiverTest, GetOnePacketEncodedFrame) { 119 TEST_F(AudioReceiverTest, GetOnePacketEncodedFrame) {
120 SimpleEventSubscriber event_subscriber; 120 SimpleEventSubscriber event_subscriber;
121 cast_environment_->Logging()->AddRawEventSubscriber(&event_subscriber); 121 cast_environment_->Logging()->AddRawEventSubscriber(&event_subscriber);
122 122
123 EXPECT_CALL(mock_transport_, SendRtcpPacket(_)).Times(1); 123 EXPECT_CALL(mock_transport_, SendRtcpPacket(_, _)).Times(1);
124 124
125 // Enqueue a request for an audio frame. 125 // Enqueue a request for an audio frame.
126 receiver_->GetEncodedAudioFrame( 126 receiver_->GetEncodedAudioFrame(
127 base::Bind(&FakeAudioClient::DeliverEncodedAudioFrame, 127 base::Bind(&FakeAudioClient::DeliverEncodedAudioFrame,
128 base::Unretained(&fake_audio_client_))); 128 base::Unretained(&fake_audio_client_)));
129 129
130 // The request should not be satisfied since no packets have been received. 130 // The request should not be satisfied since no packets have been received.
131 task_runner_->RunTasks(); 131 task_runner_->RunTasks();
132 EXPECT_EQ(0, fake_audio_client_.number_times_called()); 132 EXPECT_EQ(0, fake_audio_client_.number_times_called());
133 133
(...skipping 10 matching lines...) Expand all
144 ASSERT_TRUE(!frame_events.empty()); 144 ASSERT_TRUE(!frame_events.empty());
145 EXPECT_EQ(kAudioAckSent, frame_events.begin()->type); 145 EXPECT_EQ(kAudioAckSent, frame_events.begin()->type);
146 EXPECT_EQ(rtp_header_.frame_id, frame_events.begin()->frame_id); 146 EXPECT_EQ(rtp_header_.frame_id, frame_events.begin()->frame_id);
147 EXPECT_EQ(rtp_header_.webrtc.header.timestamp, 147 EXPECT_EQ(rtp_header_.webrtc.header.timestamp,
148 frame_events.begin()->rtp_timestamp); 148 frame_events.begin()->rtp_timestamp);
149 149
150 cast_environment_->Logging()->RemoveRawEventSubscriber(&event_subscriber); 150 cast_environment_->Logging()->RemoveRawEventSubscriber(&event_subscriber);
151 } 151 }
152 152
153 TEST_F(AudioReceiverTest, MultiplePendingGetCalls) { 153 TEST_F(AudioReceiverTest, MultiplePendingGetCalls) {
154 EXPECT_CALL(mock_transport_, SendRtcpPacket(_)) 154 EXPECT_CALL(mock_transport_, SendRtcpPacket(_, _))
155 .WillRepeatedly(testing::Return(true)); 155 .WillRepeatedly(testing::Return(true));
156 156
157 // Enqueue a request for an audio frame. 157 // Enqueue a request for an audio frame.
158 const AudioFrameEncodedCallback frame_encoded_callback = 158 const AudioFrameEncodedCallback frame_encoded_callback =
159 base::Bind(&FakeAudioClient::DeliverEncodedAudioFrame, 159 base::Bind(&FakeAudioClient::DeliverEncodedAudioFrame,
160 base::Unretained(&fake_audio_client_)); 160 base::Unretained(&fake_audio_client_));
161 receiver_->GetEncodedAudioFrame(frame_encoded_callback); 161 receiver_->GetEncodedAudioFrame(frame_encoded_callback);
162 task_runner_->RunTasks(); 162 task_runner_->RunTasks();
163 EXPECT_EQ(0, fake_audio_client_.number_times_called()); 163 EXPECT_EQ(0, fake_audio_client_.number_times_called());
164 164
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 // Move forward another 100 ms and run any pending tasks (there should be 228 // Move forward another 100 ms and run any pending tasks (there should be
229 // none). Expect no additional frames where emitted. 229 // none). Expect no additional frames where emitted.
230 testing_clock_->Advance(base::TimeDelta::FromMilliseconds(100)); 230 testing_clock_->Advance(base::TimeDelta::FromMilliseconds(100));
231 task_runner_->RunTasks(); 231 task_runner_->RunTasks();
232 EXPECT_EQ(3, fake_audio_client_.number_times_called()); 232 EXPECT_EQ(3, fake_audio_client_.number_times_called());
233 } 233 }
234 234
235 } // namespace cast 235 } // namespace cast
236 } // namespace media 236 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | media/cast/rtcp/rtcp_sender.cc » ('j') | media/cast/transport/pacing/paced_sender.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698