Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2484913005: Reland of Switch chromium.perf Android Nexus5X over to chromium recipe (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Switch chromium.perf Android Nexus5X over to chromium recipe (patchset #1 id:1 of https://codereview.chromium.org/2475193002/ ) Reason for revert: Creating reland CL; will not land immediately. Original issue's description: > Revert of Switch chromium.perf Android Nexus5X over to chromium recipe (patchset #3 id:40001 of https://codereview.chromium.org/2464143005/ ) > > Reason for revert: > Weird error, caused by bad properties?? > > Original issue's description: > > Switch chromium.perf Android Nexus5X over to chromium recipe > > > > This CL switches the Android Nexus5X builder over to the chromium recipe. > > Ideally if this works, we can switch the rest of the builders over immediatelly > > after. > > > > BUG=639530 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/3c85a1ffc8f2c1051c0e8b786df5e5d2d12e1e68 > > TBR=sullivan@chromium.org,dtu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=639530 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/6233fd91e6ffe06386cd726762504ac7b43da26f TBR=sullivan@chromium.org,dtu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=639530 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5f8bd7c6167da1cae3f8b24cf80c10e3ee961fb9

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M masters/master.chromium.perf/master.cfg View 1 2 chunks +7 lines, -5 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
martiniss
Created Reland of Switch chromium.perf Android Nexus5X over to chromium recipe
4 years, 1 month ago (2016-11-09 02:00:37 UTC) #1
martiniss
PTAL https://codereview.chromium.org/2484913005/diff/40001/masters/master.chromium.perf/master.cfg File masters/master.chromium.perf/master.cfg (right): https://codereview.chromium.org/2484913005/diff/40001/masters/master.chromium.perf/master.cfg#newcode166 masters/master.chromium.perf/master.cfg:166: bb_trigger = recipe == 'android/perf' Needs to not ...
4 years, 1 month ago (2016-11-09 02:08:59 UTC) #2
sullivan
lgtm
4 years, 1 month ago (2016-11-09 02:57:01 UTC) #3
dtu
lgtm
4 years, 1 month ago (2016-11-09 17:07:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484913005/40001
4 years, 1 month ago (2016-11-11 01:47:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/5f8bd7c6167da1cae3f8b24cf80c10e3ee961fb9
4 years, 1 month ago (2016-11-11 01:58:16 UTC) #8
martiniss
4 years, 1 month ago (2016-11-11 05:10:18 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2497533002/ by martiniss@chromium.org.

The reason for reverting is: List perf tests is broken.

Powered by Google App Engine
This is Rietveld 408576698