Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2484913004: Fix crashing bug for closures of the form () { return; } (Closed)

Created:
4 years, 1 month ago by Jacob
Modified:
4 years, 1 month ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 1 chunk +16 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jacob
4 years, 1 month ago (2016-11-08 21:22:30 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-08 21:35:29 UTC) #4
Jennifer Messerly
lgtm
4 years, 1 month ago (2016-11-08 22:28:55 UTC) #5
Jacob
4 years, 1 month ago (2016-11-08 23:14:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3356f82eb3b909aa2ac543ca280f6456c4268b00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698