Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2484903003: [Sync] Sync.ConfigureTime_Long.OK shouldn't accumulate multiple configurations (Closed)

Created:
4 years, 1 month ago by pavely
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Sync.ConfigureTime_Long.OK shouldn't accumulate multiple configurations DataTypeManagerImpl::configure_time_delta_ accumulates configure time from multiple configurations resulting in incorrect counter value. R=maxbogue@chromium.org BUG=662598 Committed: https://crrev.com/193f91d2a6129ac864af688b66c85c4e8cccd7c0 Cr-Commit-Position: refs/heads/master@{#430765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M components/sync/driver/data_type_manager_impl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/sync/driver/data_type_manager_impl.cc View 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
pavely
4 years, 1 month ago (2016-11-08 18:56:35 UTC) #3
maxbogue
lgtm; I'm still puzzled how that code structure could have ever been desirable...
4 years, 1 month ago (2016-11-08 19:00:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484903003/1
4 years, 1 month ago (2016-11-08 23:31:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 23:42:25 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:45:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/193f91d2a6129ac864af688b66c85c4e8cccd7c0
Cr-Commit-Position: refs/heads/master@{#430765}

Powered by Google App Engine
This is Rietveld 408576698