Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2484903002: DevTools: fix a crash in stopRuleUsageTracking (Closed)

Created:
4 years, 1 month ago by valih
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix a crash in stopRuleUsageTracking stopRuleUsageTracking used to crash on the NTP. BUG=663034 Committed: https://crrev.com/49cab7bcd1dd263fd9303a831b9465312567c50a Cr-Commit-Position: refs/heads/master@{#430491}

Patch Set 1 #

Patch Set 2 : stopRuleUsageTracking crash fixed #

Patch Set 3 : stopRuleUsageTracking crash fixed #

Total comments: 1

Patch Set 4 : stopRuleUsageTracking crash fixed #

Patch Set 5 : stopRuleUsageTracking crash fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/css/cssom-modify-rule-and-get-rule-list.html View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/css/cssom-modify-rule-and-get-rule-list-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
valih
4 years, 1 month ago (2016-11-07 20:00:55 UTC) #3
valih
4 years, 1 month ago (2016-11-07 21:37:21 UTC) #4
caseq
lgtm
4 years, 1 month ago (2016-11-07 21:48:17 UTC) #7
valih
4 years, 1 month ago (2016-11-08 01:25:12 UTC) #10
caseq
https://codereview.chromium.org/2484903002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/css/cssom-modify-rule-and-get-rule-list.html File third_party/WebKit/LayoutTests/inspector-protocol/css/cssom-modify-rule-and-get-rule-list.html (right): https://codereview.chromium.org/2484903002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/css/cssom-modify-rule-and-get-rule-list.html#newcode46 third_party/WebKit/LayoutTests/inspector-protocol/css/cssom-modify-rule-and-get-rule-list.html:46: InspectorTest.evaluateInPage("document.styleSheets[0].rules[0].style.setProperty('color', 'red')"); extract a function in the page called ...
4 years, 1 month ago (2016-11-08 01:27:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484903002/80001
4 years, 1 month ago (2016-11-08 01:40:57 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 02:56:13 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:27:34 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/49cab7bcd1dd263fd9303a831b9465312567c50a
Cr-Commit-Position: refs/heads/master@{#430491}

Powered by Google App Engine
This is Rietveld 408576698