Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2484883002: Highlight FieldFormalParameterElement as a field only in declaration. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-07 19:39:48 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-07 19:59:18 UTC) #2
scheglov
4 years, 1 month ago (2016-11-07 20:03:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f05952303785fc9d130bd1ad92c0ae2d4eedb867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698